Remove unreachable if-condition in refresh logic #45296
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@arushikesarwani94 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@arushikesarwani94 merged this pull request in 8c8c77b. |
|
This pull request was successfully merged by @damianstasik in 8c8c77b. When will my fix make it into a release? | How to file a pick request? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
The
hasUnrecoverableErrorsfunction has been hardcoded to always return false for the past 5 years, since React Refresh can recover from all errors. This hardcoding was introduced in react-refresh v0.7.1, and RN currently uses v0.14.2.Changelog:
[INTERNAL] [REMOVED] - Remove unreachable if-condition in refresh logic
Test Plan:
Fast Refresh should still work as expected.