Add missing sources jar into published android artifacts #32982
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @dulmandakh |
Base commit: 20b9ed9 |
Base commit: 20b9ed9 |
|
@cortinico has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
cortinico
approved these changes
Jan 28, 2022
|
This pull request was successfully merged by @Kudo in 384e1a0. When will my fix make it into a release? | Upcoming Releases |
|
thanks @cortinico! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
when migrated to
maven-publishin #31611, the sources jar is not included by default frommaven-publish. so react-native 0.66 / 0.67 doesn't include sources jar in npm published artifacts. it's not ideal for debug or tracing code.this pr added the sources jar into the published artifact.
Changelog
[Android] [Fixed] - Add missing sources jar into published android artifacts
Test Plan
make sure sources jar is included in artifact.