removed default props for drawerBackgroundColor and fixed lint issues #32162
Conversation
|
@cortinico i have not pushed the .bat files in this PR as well. Thanks for explaining what was happening. |
Base commit: a950634 |
Base commit: a950634 |
| * ); | ||
| * ``` | ||
| */ | ||
| drawerBackgroundColor?: ColorValue, |
There was a problem hiding this comment.
@lunaleaps adding drawerBackgroundColor as an optional Prop here.
There was a problem hiding this comment.
Nit: Let's make this drawerBackgroundColor?: ?ColorValue in case people spread an object with drawerBackgroundColor: null
There was a problem hiding this comment.
sure @lunaleaps will push a commit with that change so it covers all edge cases!
|
@cortinico has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
|
@cortinico has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
|
@cortinico merged this pull request in b998e32. |
Summary
Removed the deaultProps in the DrawerLayoutAndroid file and replaced it with a default value in case props are undefined.
Changelog
[General] [Changed] - Remove defaultProps from the DrawerLayoutAndroid Component. @lunaleaps this is the fix for issue #31606
Test Plan
Ran test suite