Sync React with Haste-style imports rewritten to use path-based imports instead #25010
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ts instead This commit uses the same base commit of React that's currently in RN (React ec6691a68716bc59291746fc62f374a56fb435c9) plus a commit in the React repo that removes Haste-style imports (React 61f62246c8cfb76a4a19d1661eeaa5822ec37b36). The resulting commit hash is 13d0561d30a4da10002e56ad1519d1dfc4d2e1ba. I built React in the React repo with `yarn build`, copied over the `oss` and `shims` directories, and updated `REVISION` to the new commit hash (13d0561d30a4da10002e56ad1519d1dfc4d2e1ba). Test plan: run unit tests, CI
This was referenced May 23, 2019
|
Closing this since we need to figure out how to deal with the shims. This PR doesn't break anything but it doesn't fully move us to standard imports. The issue is that the shims still rely on Haste so that FB can internally use a different React renderer than the OSS repo does. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This commit uses the same base commit of React that's currently in RN (React ec6691a68716bc59291746fc62f374a56fb435c9) plus a commit in the React repo that removes Haste-style imports (React 61f62246c8cfb76a4a19d1661eeaa5822ec37b36). The resulting commit hash is 13d0561d30a4da10002e56ad1519d1dfc4d2e1ba.
I built React in the React repo with
yarn build, copied over theossandshimsdirectories, and updatedREVISIONto the new commit hash (13d0561d30a4da10002e56ad1519d1dfc4d2e1ba).This is part of #24770.
Changelog
[General] [Changed] - Sync React with Haste-style imports rewritten to use path-based imports instead
Test Plan
Test plan: run unit tests, CI