Skip to content

There is a small gap in the SynchronizedWeakHashSet implementation. T… #24015

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

There is a small gap in the SynchronizedWeakHashSet implementation. T… #24015

wants to merge 1 commit into from

Conversation

dryganets
Copy link
Contributor

Summary

There is a small gap in the SynchronizedWeakHashSet implementation - the containsKey method of the WeakHashMap is modifying hence calling it during the iteration might cause ConcurrentModificationException. Added a command DO_IF_CONTAINS to safely handle this case.

Changelog

[Android] [Bugfix] - Should fix a ConcurrentModificationException in onResume.

Test Plan

It is hard to reproduce this problem as this is a race condition.
You rather need to have a good set of integration tests or check it in production.

@dryganets
There is a small gap in the SynchronizedWeakHashSet implementation. T…
2a2d4e3 
…he containsKey method of the WeakHashMap is modifying hence calling it during the iteration might cause ConcurrentModificationException. Added a command DO_IF_CONTAINS to safely handle this case.
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 18, 2019
@pull-bot
Copy link

Messages
📖

📋 Changelog Format - Did you include a Changelog? A changelog entry has the following format: [CATEGORY] [TYPE] - Message.

CATEGORY may be:
  • General
  • iOS
  • Android

TYPE may be:

  • Added, for new features.
  • Changed, for changes in existing functionality.
  • Deprecated, for soon-to-be removed features.
  • Removed, for now removed features.
  • Fixed, for any bug fixes.
  • Security, in case of vulnerabilities.

MESSAGE may answer "what and why" on a feature level. Use this to briefly tell React Native users about notable changes.

Generated by 🚫 dangerJS against 2a2d4e3

@dryganets dryganets mentioned this pull request Mar 18, 2019
Closed
facebook-github-bot
facebook-github-bot reviewed Mar 18, 2019
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fkgozali has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@react-native-bot
Copy link
Collaborator

This pull request was successfully merged by @dryganets in 62d3409.

When will my fix make it into a release? | Upcoming Releases

@react-native-bot react-native-bot added the Merged This PR has been merged. label Mar 18, 2019
@fkgozali
Copy link
Contributor

Thanks for the fix! We'll update you if related crash still happens in the future. cc @cpojer

@fkgozali
Copy link
Contributor

fkgozali commented Mar 28, 2019 •
edited
Loading

@dryganets - looks like the same crash is still happening:

9Caused by: java.util.ConcurrentModificationException
10java.util.WeakHashMap$HashIterator.nextEntry(WeakHashMap.java:789)
11java.util.WeakHashMap$KeyIterator.next(WeakHashMap.java:822)
12+com.facebook.react.bridge.SynchronizedWeakHashSet.iterate(SynchronizedWeakHashSet.java:63)
13+com.facebook.react.bridge.ReactContext.onHostResume(ReactContext.java:218)
14+com.facebook.react.ReactInstanceManager.moveToResumedLifecycleState(ReactInstanceManager.java:660)
15+com.facebook.react.ReactInstanceManager.onHostResume(ReactInstanceManager.java:579)
16+com.facebook.react.ReactInstanceManager.onHostResume(ReactInstanceManager.java:535)

It's on the same line as before in SynchronizedWeakHashSet.java:

      for (T listener: mMap.keySet()) {

Thoughts on further corner cases to handle? cc @cpojer

@dryganets
Copy link
Contributor Author

@fkgozali,
I don't see how this could happen now.
All the methods are synchronized.

The iterators are protected with the lock.
For the same thread ConcurrentModification, I had a boolean variable and it was protected with the same lock.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@facebook-github-bot facebook-github-bot facebook-github-bot left review comments

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. p: Microsoft Partner: Microsoft Partner
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dryganets @pull-bot @react-native-bot @fkgozali @facebook-github-bot