Skip to content

[WebSocket] binaryType='arraybuffer' support #1829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[WebSocket] binaryType='arraybuffer' support #1829

wants to merge 1 commit into from

Conversation

orktes
Copy link

@orktes orktes commented Jul 1, 2015

Support for binary websocket messages. Currently binary messages crash the application. More info in #1730

@facebook-github-bot
Copy link
Contributor

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks!

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 1, 2015
@apitaru apitaru mentioned this pull request Aug 19, 2015
Closed
@mikemintz mikemintz mentioned this pull request Sep 23, 2015
Open
@lindskogen
Copy link
Contributor

@orktes, or someone? Would you take a look at this and see what's failing?

@facebook-github-bot
Copy link
Contributor

@orktes updated the pull request.

@lindskogen
Copy link
Contributor

@orktes Looks like it's just the .flowconfig-file that needs to be brought up to latest version, mind taking a look at it?

@lindskogen lindskogen mentioned this pull request Dec 2, 2015
Closed
@satya164
Copy link
Contributor

Closing in favour of #4483

@satya164 satya164 closed this Dec 22, 2015
ghost pushed a commit that referenced this pull request Dec 23, 2015
@lindskogen
Add support for binary type data (ArrayBuffer)
afbff9b 
Summary:
Entirely based on #1829
I just updated the diff to be compatible with the current master branch.
Closes #4483

Reviewed By: svcscm

Differential Revision: D2783425

Pulled By: nicklockwood

fb-gh-sync-id: 1cc67c0741cff3b071530877d688f6b8c1061e3f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@tadeuzagallo tadeuzagallo

Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@orktes @facebook-github-bot @lindskogen @satya164 @tadeuzagallo