-
Notifications
You must be signed in to change notification settings - Fork 24.8k
16111 Webview contentInset docs change #16138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
16111 Webview contentInset docs change #16138
Conversation
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
@facebook-github-bot shipit |
I cannot do that @janicduplessis, because @paulbrittain does not have an active CLA on file. |
@paulbrittain Could you sign the CLA please? |
@janicduplessis signed |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
@facebook-github-bot shipit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@janicduplessis is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
@janicduplessis Seems this PR hasnt gone live. The doc isnt reflecting the platform. |
Addresses #16111
Test Plan
No tests needed, non functional change. Test suite ran: PASS