add node/npm version to ISSUE_TEMPLATE.md #14422
Conversation
.github/ISSUE_TEMPLATE.md
Outdated
| @@ -39,6 +39,7 @@ What needs to be done to address this issue? Ideally, provide a pull request wit | |||
| ### Additional Information | |||
|
|
|||
| * React Native version: [FILL THIS OUT: Be specific, filling out "latest" here is not enough.] | |||
| * Node/npm version: [FILL THIS OUT: `node -v` and `npm -v`] | |||
There was a problem hiding this comment.
Can you add yarn here? If yarn is installed, it will be used instead of npm.
There was a problem hiding this comment.
Can do - also this may depend on #14428
We may want to wait until this one is finished.
There was a problem hiding this comment.
Added yarn next to npm, gave node its own line. Also reordered and added hint about react-native info to coincide with #14428
|
We can merge this once |
|
@hramos considering the changes in the mean time, might it be better to close this issue, rebase my other PR and include this in that one? |
|
@tabrindle I tried to find reviewers for this pull request and wanted to ping them to take another look. However, based on the blame information for the files in this pull request I couldn't find any reviewers. This sometimes happens when the files in the pull request are new or don't exist on master anymore. Is this pull request still relevant? If yes could you please rebase? In case you know who has context on this code feel free to mention them in a comment (one person is fine). Thanks for reading and hope you will continue contributing to the project. |
|
Hey @hramos I can either update this PR or submit a completely new one based on the changes I've made with react native info and your template. Which do you prefer? |
|
Updating this one seems fine. |
|
@hramos - updated, ready for review. |
|
@facebook-github-bot label Core Team Generated by 🚫 dangerJS |
.github/ISSUE_TEMPLATE.md
Outdated
| @@ -29,24 +29,40 @@ | |||
| ### Environment | |||
|
|
|||
| <!-- | |||
| Please fill in all the relevant fields by running these commands in terminal. | |||
| If you are on v0.48.0 or greater, please run `react-native info` and paste its contents here then specify target platform, like this: | |||
There was a problem hiding this comment.
We don't want to encourage people to open issues for old releases, and 0.48 is already the current stable. Can you rewrite this a bit so that it assumes people are using 0.48 or newer? Just have them run react-native info, and maybe add a note saying that if they get (insert whatever error is shown if they're not using 0.48+) then they should make sure they're using a recent version of React Native.
That way we can remove the whole next section that asks people to run several commands.
There was a problem hiding this comment.
Sounds good to me. Will update.
- we want to encourage updates to newer versions of react-native
|
@hramos has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Motivation
A huge number of Issues are opened with some key information about node/npm versions missing. Adding this information as a required part of the ISSUE_TEMPLATE may help issues get closed faster.
Test Plan
Once merged in, check ISSUE_TEMPLATE by opening new issue, verify new line is there.