-
Notifications
You must be signed in to change notification settings - Fork 24.8k
Closed
Labels
PartnerRN TeamRan CommandsOne of our bots successfully processed a command.One of our bots successfully processed a command.Resolution: LockedThis issue was locked by the bot.This issue was locked by the bot.Type: DiscussionLong running discussion.Long running discussion.Type: EnhancementA new feature or enhancement of an existing feature.A new feature or enhancement of an existing feature.p: FacebookPartner: FacebookPartner: Facebook
Description
This is the list of remaining things to do before we can ship the new app screen (see react-native-community/discussions-and-proposals#122). The initial version of the code was landed via #24737:
- Fix up the styling and color names a bit more.
- Split up the components the way @orta proposed so we'll have some good sample code in the App.js template.
- Make it so that links tapped will send an open-in-browser command via Metro on the host instead of in the emulator. See https://github.com/react-native-community/cli/blob/885f2c28d4e8ed66e334fd7bd0174173b2a394e1/packages/cli/src/commands/server/middleware/openStackFrameInEditorMiddleware.js for how we are doing this in the cli/metro (this may need some changes to the CLI and Metro) and https://github.com/facebook/react-native/blob/1151c096dab17e5d9a6ac05b61aacecd4305f3db/Libraries/Core/Devtools/openFileInEditor.js (@lucasbento)
- Add a "Follow us on Twitter" button 😄
- Actually put this all in the template so it can be shipped as part of 0.61.
cc @eliperkins @lucasbento would be awesome if you could help out! :)
lucasbento, eliperkins and ecreethlucasbento and ecreethecreeth
Metadata
Metadata
Assignees
Labels
PartnerRN TeamRan CommandsOne of our bots successfully processed a command.One of our bots successfully processed a command.Resolution: LockedThis issue was locked by the bot.This issue was locked by the bot.Type: DiscussionLong running discussion.Long running discussion.Type: EnhancementA new feature or enhancement of an existing feature.A new feature or enhancement of an existing feature.p: FacebookPartner: FacebookPartner: Facebook