-
Notifications
You must be signed in to change notification settings - Fork 24.8k
Description
Is this a bug report?
Yes. I guess. More like an improvement.
Have you read the Contributing Guidelines?
Yes
Environment
$ react-native info
Unrecognized command 'info'
Steps to Reproduce
-
Edit
Debug server host & port for device
. -
Enter in a value that includes
http://
. -
When trying to connect to the React Native packager, it will try
http://http://...
.
Expected Behavior
I would expect that it to smartly not add http://
to an address that already contains http://
.
Actual Behavior
It adds http://
to the address, thus duplicating it to http://http://
Reproducible Demo
Not necessary. Just launch the dev menu and see for yourself.
My Notes
When adding the IP address and port number for the React Native packager, the "http://" is automatically added. So, when people add "http://127.0.0.1:8081" in here, it tried to find the React Native package server at "http://http://127.0.0.1:8081".
I accidentally do this all the time and I'm sure others, especially newcomers, do as well.
I'm happy to issue a PR to make this more friendly but wanted to get your opinion on the direction.
-
Add a prefix to the EditText that shows "http://" so that it hints to the developer that there is no need to enter in the "http://" part.
-
When accepting the value, if the string starts with "http://" remove it.
-
When using the value, if the string starts with "http://" don't add it.
I'm leaning towards 3.
Let me know what you think and I'll take a look.
Thanks.
Josh