-
Notifications
You must be signed in to change notification settings - Fork 24.8k
Closed
Labels
Help Wanted
Issues ideal for external contributors.Issues ideal for external contributors.Ran CommandsOne of our bots successfully processed a command.One of our bots successfully processed a command.StaleThere has been a lack of activity on this issue and it may be closed soon.There has been a lack of activity on this issue and it may be closed soon.
Description
Is this a bug report?
Yes (Mostly)
Have you read the Contributing Guidelines?
Yes
Environment
react-native -v
: 0.48.3node -v
: v8.4.0npm -v
: 5.3.0yarn --version
: 0.23.4
- Target Platform: iOS11
- Development Operating System: macOS 10.12.6 (16G29)
- Build tools: XCode 9 beta
Steps to Reproduce
- Want to automate the
RCTWebSocketExecutor
react-devtools host detection. sed -i ''
it all the way... Anyways, I'm using ngrok, so, it's a bit bothersome.- Well, if
RCTBundleURLProvider
already has guessPackagerHost method which usesip.txt
file in the main bundle, we could use that to pass the hostname for theRCTWebSocketExecutor
.
Expected Behavior
Less regex's and manual RCTWebSocketExecutor
patching.
Actual Behavior
Official documentation states explicitly to patch the RCTWebSocketExecutor.m
file which isn't a great way of handling such things.
Metadata
Metadata
Assignees
Labels
Help Wanted
Issues ideal for external contributors.Issues ideal for external contributors.Ran CommandsOne of our bots successfully processed a command.One of our bots successfully processed a command.StaleThere has been a lack of activity on this issue and it may be closed soon.There has been a lack of activity on this issue and it may be closed soon.