Circle CI has been red for a while now. I've identified several different causes, each of which we'll need to address before Circle CI can get back to green.

Every day Circle remains red, we risk adding more breakages that don't get caught -- we usually get into this state when people start ignoring Circle failures due to it already failing on master prior to a diff getting landed.

Issues that need to be addressed

• Flow errors, fixed.
• Buck errors (see details below). Task has been opened internally for followup.
• local-cli test fails due to use of trailing commas in function argument list in metro-bundler. Potential fix: update Circle, Travis to Node 8.2.0, OR remove use of trailing commas in metro-bundler.
• Flow errors, again - requiring a similar fix as above.

Buck errors

One of the buck install steps started failing on Circle CI in open source after D5651764 landed. Travis CI was already failing for unrelated issues, so this particular failure wasn't noticed back then.

Circle CI job:
Every job running on master since D5651764 landed, starting with https://circleci.com/gh/facebook/react-native/20393

Command:

buck install ReactAndroid/src/androidTest/buck-runner:instrumentation-tests --config build.threads=1

Errors:

buck-out/gen/ReactAndroid/src/main/res/shell#resources-symlink-tree/res/values/styles.xml:3: error: Error retrieving parent for item: No resource found that matches the given name '@style/Theme.AppCompat.Light.NoActionBar'.
stderr: buck-out/gen/ReactAndroid/src/main/res/shell#resources-symlink-tree/res/values/styles.xml:3: error: Error retrieving parent for item: No resource found that matches the given name '@style/Theme.AppCompat.Light.NoActionBar'.