Skip to content

Add additional accessibility roles and states to the documentation. #912

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 13, 2019
Merged

Add additional accessibility roles and states to the documentation. #912

merged 1 commit into from
May 13, 2019

Conversation

marcmulcahy
Copy link
Contributor

This PR adds the additional accessibility roles and states added in facebook/react-native#24095

@marcmulcahy marcmulcahy mentioned this pull request May 6, 2019
Closed
@react-native-bot
Copy link

Deploy preview for react-native ready!

Built with commit e4c6c44

https://deploy-preview-912--react-native.netlify.com

Changes to docs/ are reflected in the next "master" version.

Thank you for your contributions.

How to Contribute • Documentation Sources

@estevaolucas
Copy link

@marcmulcahy do you mind to update docs/view.md as well because it also has references accessibiltyRole and accessibilityStates (https://facebook.github.io/react-native/docs/view#accessibilityrole). Thanks

cpojer
cpojer approved these changes May 13, 2019
View reviewed changes
Copy link
Contributor

@cpojer cpojer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you for updating this here!

@cpojer cpojer merged commit 51b8679 into facebook:master May 13, 2019
@marcmulcahy marcmulcahy deleted the a11y-docs branch May 22, 2019 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@cpojer cpojer cpojer approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@marcmulcahy @react-native-bot @estevaolucas @cpojer