[Flight] Allow Temporary References to be awaited #34084
Merged
+49
−37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Same as #33761 basically. I just saw it. I landed that one but rebased with my test/comment which has a bit more coverage. |
|
Comparing: 1d16396...9c79367 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: (No significant changes) |
305cfc4 to
9c79367
Compare
rickhanlonii
approved these changes
Aug 2, 2025
eps1lon
reviewed
Aug 4, 2025
Comment on lines
-73
to
+78
| // Allow returning a temporary reference from an async function | ||
| case 'then': | ||
| // Allow returning a temporary reference from an async function | ||
| // Unlike regular Client References, a Promise would never have been serialized as | ||
| // an opaque Temporary Reference, but instead would have been serialized as a | ||
| // Promise on the server and so doesn't hit this path. So we can assume this wasn't | ||
| // a Promise on the client. |
There was a problem hiding this comment.
The actual diff is in #33761. This is just about adding an explainer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #33534.
.thenmethod can be tested when you await a value that's not a Promise. For regular Client References we have a way to mark those as "async" and yield a reference to the unwrapped value in case it's a Promise on the Client.However, the realization is that we never serialize Promises as opaque when passed from the client to the server. If a Promise is passed, then it would've been deserialized as a Promise (while still registered as a temporary reference) and not one of these Proxy objects.
Technically it could be a non-function value on the client which would be wrong but you're not supposed to dot into it in the first place.
So we can just assume it's
undefined.