Skip to content

Conversation

sebmarkbage
Copy link
Collaborator

@sebmarkbage sebmarkbage commented May 22, 2025

Follow up to #33293.

This solves a race condition when boundaries are added to the batch after the startViewTransition call.

This doesn't matter yet but it will once we start assigning names before the startViewTransition call.

A possible alternative solution might be to ensure the names are added synchronously in the event that adds to the batch. It's possible to keep adding to a batch until the snapshot has happened.

This solves a race condition when boundaries are added to the batch after
the startViewTransition call.
@sebmarkbage sebmarkbage requested a review from gnoff May 22, 2025 00:14
@github-actions github-actions bot added the React Core Team Opened by a member of the React Core Team label May 22, 2025
@react-sizebot
Copy link

Comparing: 459a2c4...4d0942d

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB +0.05% 1.83 kB 1.83 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 529.83 kB 529.83 kB = 93.52 kB 93.52 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB = 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 651.62 kB 651.62 kB = 114.80 kB 114.80 kB
facebook-www/ReactDOM-prod.classic.js = 675.87 kB 675.87 kB = 118.93 kB 118.93 kB
facebook-www/ReactDOM-prod.modern.js = 666.15 kB 666.15 kB = 117.31 kB 117.31 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
oss-experimental/react-dom/unstable_server-external-runtime.js +1.20% 10.16 kB 10.28 kB +0.63% 2.70 kB 2.72 kB

Generated by 🚫 dangerJS against 4d0942d

@sebmarkbage sebmarkbage requested a review from rickhanlonii May 22, 2025 00:22
@sebmarkbage sebmarkbage merged commit 91ac1fe into facebook:main May 22, 2025
246 checks passed
github-actions bot pushed a commit that referenced this pull request May 22, 2025
Follow up to #33293.

This solves a race condition when boundaries are added to the batch
after the `startViewTransition` call.

This doesn't matter yet but it will once we start assigning names before
the `startViewTransition` call.

A possible alternative solution might be to ensure the names are added
synchronously in the event that adds to the batch. It's possible to keep
adding to a batch until the snapshot has happened.

DiffTrain build for [91ac1fe](91ac1fe)
sebmarkbage added a commit that referenced this pull request May 22, 2025
#33332)

Stacked on #33330.

This walks the element tree to activate the various classes under
different scenarios. There are some edge case things that are a little
different since we can't express every scenario without virtual nodes.

The main thing that's still missing though is avoiding animating updates
if it can be contained to a layout or enter/exit/share if they're out of
the viewport. I.e. layout stuff.
github-actions bot pushed a commit that referenced this pull request May 22, 2025
#33332)

Stacked on #33330.

This walks the element tree to activate the various classes under
different scenarios. There are some edge case things that are a little
different since we can't express every scenario without virtual nodes.

The main thing that's still missing though is avoiding animating updates
if it can be contained to a layout or enter/exit/share if they're out of
the viewport. I.e. layout stuff.

DiffTrain build for [8ce15b0](8ce15b0)
github-actions bot pushed a commit to code/lib-react that referenced this pull request May 22, 2025
facebook#33332)

Stacked on facebook#33330.

This walks the element tree to activate the various classes under
different scenarios. There are some edge case things that are a little
different since we can't express every scenario without virtual nodes.

The main thing that's still missing though is avoiding animating updates
if it can be contained to a layout or enter/exit/share if they're out of
the viewport. I.e. layout stuff.

DiffTrain build for [8ce15b0](facebook@8ce15b0)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants