Skip to content

Move SuspenseListProps into a shared/ReactTypes #33298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 18, 2025
Merged

Move SuspenseListProps into a shared/ReactTypes #33298

merged 1 commit into from
May 18, 2025

Conversation

sebmarkbage
Copy link
Collaborator

So they can be shared by server. Incorporates the types from definitely typed too.

@sebmarkbage sebmarkbage requested a review from eps1lon May 17, 2025 22:37
@github-actions github-actions bot added the React Core Team Opened by a member of the React Core Team label May 17, 2025
@react-sizebot
Copy link

Comparing: 6060367...f8bf59f

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB = 1.83 kB 1.83 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 529.74 kB 529.74 kB = 93.49 kB 93.49 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB = 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 651.48 kB 651.48 kB = 114.76 kB 114.76 kB
facebook-www/ReactDOM-prod.classic.js = 675.72 kB 675.72 kB = 118.85 kB 118.85 kB
facebook-www/ReactDOM-prod.modern.js = 666.00 kB 666.00 kB = 117.23 kB 117.23 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against f8bf59f

rickhanlonii
rickhanlonii approved these changes May 17, 2025
View reviewed changes
Copy link
Member

@rickhanlonii rickhanlonii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

@sebmarkbage sebmarkbage merged commit 462d08f into facebook:main May 18, 2025
246 checks passed
github-actions bot pushed a commit to code/lib-react that referenced this pull request May 18, 2025
@pull
Move SuspenseListProps into a shared/ReactTypes (facebook#33298)
26de3cd 
So they can be shared by server. Incorporates the types from definitely
typed too.

DiffTrain build for [462d08f](facebook@462d08f)
This was referenced May 19, 2025
Merged
Merged
Closed
Closed
Closed
@eps1lon eps1lon mentioned this pull request Jun 7, 2025
Merged
17 tasks
This was referenced Jun 23, 2025
Merged
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rickhanlonii rickhanlonii rickhanlonii approved these changes

@eps1lon eps1lon Awaiting requested review from eps1lon

Assignees
No one assigned
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sebmarkbage @react-sizebot @rickhanlonii @facebook-github-bot