Skip to content

[Flight] Use valid CSS selectors in useId format #33099

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 4, 2025
Merged

[Flight] Use valid CSS selectors in useId format #33099

merged 1 commit into from
May 4, 2025

Conversation

eps1lon
Copy link
Collaborator

@eps1lon eps1lon commented May 2, 2025

Resolves #32001 (comment)

Summary

#32001 only applied to Fiber and Fizz. This makes the same change for Flight.

How did you test this change?

  • updated tests

@eps1lon eps1lon requested a review from sebmarkbage May 2, 2025 15:48
@eps1lon eps1lon changed the title [Flight] Use valid CSS selectors in useId format [Flight] Use valid CSS selectors in useId format May 2, 2025
@github-actions github-actions bot added the React Core Team Opened by a member of the React Core Team label May 2, 2025
@react-sizebot
Copy link

react-sizebot commented May 2, 2025 •
edited
Loading

Comparing: f739642...a8ed43b

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB = 1.83 kB 1.83 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 528.27 kB 528.27 kB = 93.14 kB 93.14 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB = 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 633.90 kB 633.90 kB = 111.33 kB 111.33 kB
facebook-www/ReactDOM-prod.classic.js = 671.68 kB 671.68 kB = 117.77 kB 117.77 kB
facebook-www/ReactDOM-prod.modern.js = 661.96 kB 661.96 kB = 116.21 kB 116.21 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against a8ed43b

@kachkaev kachkaev mentioned this pull request May 2, 2025
Closed
@eps1lon eps1lon force-pushed the sebbie/flight-use-id-valid-css branch from 6f9636d to a8ed43b Compare May 2, 2025 16:03
@eps1lon eps1lon merged commit 0ca8420 into facebook:main May 4, 2025
239 checks passed
github-actions bot pushed a commit that referenced this pull request May 4, 2025
@eps1lon
[Flight] Use valid CSS selectors in useId format (#33099)
16e2c88 
DiffTrain build for [0ca8420](0ca8420)
github-actions bot pushed a commit to code/lib-react that referenced this pull request May 4, 2025
@pull
[Flight] Use valid CSS selectors in useId format (facebook#33099)
a1df8f3 
DiffTrain build for [0ca8420](facebook@0ca8420)
@kachkaev
Copy link
Contributor

kachkaev commented May 4, 2025 •
edited
Loading

Many thanks for fixing this so quickly @eps1lon! 🙌

Before writing #32001 (comment), I tried searching for s1 in the repo but it did not give any relevant results. It turned out that I had to search for :s1: instead. Useful to know that GitHub indexing is sensitive to punctuation in this case.

This was referenced May 5, 2025
Closed
Closed
Closed
Closed
Closed
Closed
This was referenced May 12, 2025
Merged
Merged
Merged
Merged
Closed
This was referenced May 19, 2025
Merged
Merged
Closed
Closed
@kachkaev kachkaev mentioned this pull request Jun 4, 2025
Merged
17 tasks
This was referenced Jun 23, 2025
Merged
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebmarkbage sebmarkbage sebmarkbage approved these changes

Assignees
No one assigned
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@eps1lon @react-sizebot @kachkaev @sebmarkbage @facebook-github-bot