Ship enableFabricCompleteRootInCommitPhase #33064
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Comparing: 408d055...79cbf48 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: Expand to show
|
sebmarkbage
reviewed
May 5, 2025
| if (enableFabricCompleteRootInCommitPhase) { | ||
| completeRoot(container.containerTag, newChildren); | ||
| } | ||
| completeRoot(container.containerTag, newChildren); |
There was a problem hiding this comment.
This should probably be renamed to commitRoot to align with React terminology. Really these should exist in both forms. Both completeRoot (which would really do layout eagerly) and commitRoot. This is the commitRoot part.
github-actions bot
pushed a commit
to code/lib-react
that referenced
this pull request
May 5, 2025
This was shipped internally. Cleaning up the flag. DiffTrain build for [edf550b](facebook@edf550b)
github-actions bot
pushed a commit
to code/lib-react
that referenced
this pull request
May 5, 2025
This was shipped internally. Cleaning up the flag. DiffTrain build for [edf550b](facebook@edf550b)
This was referenced May 6, 2025
This was referenced May 13, 2025
This was referenced May 21, 2025
17 tasks
jackpope
added a commit
that referenced
this pull request
Jul 16, 2025
This was shipped internally. Cleaning up the flag.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was shipped internally. Cleaning up the flag.