Skip to content

[Release] Update build script to properly set React Native's renderers version #33972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 24, 2025
Merged

[Release] Update build script to properly set React Native's renderers version #33972

merged 1 commit into from
Jul 24, 2025

Conversation

cipolleschi
Copy link

@cipolleschi cipolleschi commented Jul 23, 2025 •
edited
Loading

Summary

The React Native's renderers files for OSS that are produced by CI in the combined_artifacts artifact used to have a wrong version. In fact, when syncing React into React Native for React 19.1, I had to manually adjust the renderer's versions and sign them again to make them work.

With this change, the build script will take care of updating the files properly. I also refactored the code a little to avoid some duplicated code.

How did you test this change?

# move to this commit
yarn install
yarn build
open build/react-native/implementations/ReactFabric-dev.js

once the file is open, cmd+F for version: and observe that the versions are properly set.

BEFORE AFTER
Screenshot 2025-07-23 at 15 55 00 Screenshot 2025-07-23 at 15 53 24

@cipolleschi cipolleschi changed the base branch from main to release/19.1.1 July 23, 2025 14:48
@cipolleschi cipolleschi marked this pull request as ready for review July 23, 2025 14:55
jackpope
jackpope approved these changes Jul 23, 2025
View reviewed changes
Copy link
Member

@jackpope jackpope left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Do we need the prerelease versioning for anything else? For react we have both a prerelease build and a semver stable build here. Not sure if we need two copied for react-native as well?

@cipolleschi
Copy link
Author

Looks good to me. Do we need the prerelease versioning for anything else? For react we have both a prerelease build and a semver stable build here. Not sure if we need two copied for react-native as well?

I don't think so. We always use React from NPM, and currently React Native does not support prerelease versions, so I don't see how we can actually use a prerelease channel.

@cipolleschi cipolleschi merged commit 3f178f5 into release/19.1.1 Jul 24, 2025
13 checks passed
@cipolleschi cipolleschi deleted the cipolleschi/fix-release-script-for-react-native branch July 24, 2025 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackpope jackpope jackpope approved these changes

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cipolleschi @jackpope @facebook-github-bot