Skip to content

Conversation

kassens
Copy link
Member

@kassens kassens commented Jun 30, 2025

Original commit changeset: 65c4dec

This was removed by dead code removal. Adding back the TODO with commented out code.

Original commit changeset: 65c4dec

This was removed by dead code removal. Adding back the TODO with commented out code.
@kassens kassens requested a review from eps1lon June 30, 2025 17:00
@github-actions github-actions bot added the React Core Team Opened by a member of the React Core Team label Jun 30, 2025
@react-sizebot
Copy link

Comparing: 65c4dec...4d72694

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB +0.11% 1.83 kB 1.83 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 530.57 kB 530.57 kB = 93.67 kB 93.67 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB +0.05% 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 651.66 kB 651.66 kB = 114.78 kB 114.78 kB
facebook-www/ReactDOM-prod.classic.js = 674.81 kB 674.81 kB = 118.78 kB 118.78 kB
facebook-www/ReactDOM-prod.modern.js = 665.30 kB 665.30 kB = 117.19 kB 117.20 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against 4d72694

Copy link
Member

@poteto poteto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting, we should probably disallow that bot in the synced source directory

@kassens kassens merged commit 6a3d16c into facebook:main Jun 30, 2025
247 checks passed
@kassens kassens deleted the pr33673 branch June 30, 2025 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants