Fix CI #33578
Merged
Fix CI #33578
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eps1lon
commented
Jun 19, 2025
Comment on lines
-304
to
-306
| restore-keys: | | ||
| runtime-and-compiler-node_modules-v6-${{ runner.arch }}-${{ runner.os }}- | ||
| runtime-and-compiler-node_modules-v6- |
There was a problem hiding this comment.
This leads to growing the cache indefinitely when packages changes: mui/material-ui#29040
Since we don't actively monitor install times, it's safer to deopt in the rare case instead of permanently deopting after dependencies have changed multiple times.
rickhanlonii
approved these changes
Jun 19, 2025
|
Sizebot failure is expected because Git base is broken. |
17 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The cache wants to restore runtime and compiler dependencies. If we miss, we need to install both.
test plan