Skip to content

[Fizz] Include unit of threshold in rel=expect deopt error #33476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 7, 2025
Merged

[Fizz] Include unit of threshold in rel=expect deopt error #33476

merged 1 commit into from
Jun 7, 2025

Conversation

eps1lon
Copy link
Collaborator

@eps1lon eps1lon commented Jun 6, 2025

We display kilobytes.

@github-actions github-actions bot added the React Core Team Opened by a member of the React Core Team label Jun 6, 2025
@eps1lon eps1lon requested a review from sebmarkbage June 6, 2025 23:43
@react-sizebot
Copy link

Comparing: 280ff6f...2b1cb18

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB +0.05% 1.83 kB 1.83 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 530.07 kB 530.07 kB = 93.57 kB 93.57 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB +0.11% 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 651.16 kB 651.16 kB = 114.69 kB 114.69 kB
facebook-www/ReactDOM-prod.classic.js = 676.11 kB 676.11 kB = 118.97 kB 118.97 kB
facebook-www/ReactDOM-prod.modern.js = 666.39 kB 666.39 kB = 117.36 kB 117.36 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against 2b1cb18

@eps1lon eps1lon merged commit b3d5e90 into facebook:main Jun 7, 2025
247 checks passed
github-actions bot pushed a commit that referenced this pull request Jun 7, 2025
@eps1lon
[Fizz] Include unit of threshold in rel=expect deopt error (#33476)
42b6956 
DiffTrain build for [b3d5e90](b3d5e90)
This was referenced Jun 9, 2025
Merged
Merged
Merged
Closed
@eps1lon eps1lon mentioned this pull request Jun 20, 2025
Merged
17 tasks
This was referenced Jun 23, 2025
Merged
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebmarkbage sebmarkbage sebmarkbage approved these changes

Assignees
No one assigned
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@eps1lon @react-sizebot @sebmarkbage @facebook-github-bot