Skip to content

[Fizz] Add Web Streams to Fizz Node entry point #33475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 7, 2025
Merged

[Fizz] Add Web Streams to Fizz Node entry point #33475

merged 1 commit into from
Jun 7, 2025

Conversation

sebmarkbage
Copy link
Collaborator

New take on #33441.

This uses a wrapper instead of a separate bundle.

@github-actions github-actions bot added the React Core Team Opened by a member of the React Core Team label Jun 6, 2025
@react-sizebot
Copy link

Comparing: 280ff6f...5457bb3

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB +0.11% 1.83 kB 1.83 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 530.07 kB 530.07 kB = 93.57 kB 93.57 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB +0.11% 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 651.16 kB 651.16 kB = 114.69 kB 114.70 kB
facebook-www/ReactDOM-prod.classic.js = 676.11 kB 676.11 kB = 118.97 kB 118.97 kB
facebook-www/ReactDOM-prod.modern.js = 666.39 kB 666.39 kB = 117.36 kB 117.36 kB
oss-experimental/react-dom/static.node.js +23.27% 0.36 kB 0.45 kB +4.02% 0.20 kB 0.21 kB
oss-stable-semver/react-dom/static.node.js +23.27% 0.36 kB 0.45 kB +4.02% 0.20 kB 0.21 kB
oss-stable/react-dom/static.node.js +23.27% 0.36 kB 0.45 kB +4.02% 0.20 kB 0.21 kB
oss-experimental/react-dom/server.node.js +17.12% 0.62 kB 0.73 kB +6.75% 0.25 kB 0.27 kB
oss-stable-semver/react-dom/server.node.js +17.12% 0.62 kB 0.73 kB +6.75% 0.25 kB 0.27 kB
oss-stable/react-dom/server.node.js +17.12% 0.62 kB 0.73 kB +6.75% 0.25 kB 0.27 kB
oss-experimental/react-dom/cjs/react-dom-server.node.production.js +3.26% 295.51 kB 305.15 kB +1.11% 52.54 kB 53.13 kB
oss-experimental/react-dom/cjs/react-dom-server.node.development.js +2.46% 447.51 kB 458.51 kB +0.81% 78.47 kB 79.11 kB
oss-stable-semver/react-dom/cjs/react-dom-server.node.production.js +2.41% 253.72 kB 259.84 kB +1.09% 45.98 kB 46.48 kB
oss-stable/react-dom/cjs/react-dom-server.node.production.js +2.41% 253.79 kB 259.92 kB +1.10% 46.01 kB 46.51 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
oss-experimental/react-dom/static.node.js +23.27% 0.36 kB 0.45 kB +4.02% 0.20 kB 0.21 kB
oss-stable-semver/react-dom/static.node.js +23.27% 0.36 kB 0.45 kB +4.02% 0.20 kB 0.21 kB
oss-stable/react-dom/static.node.js +23.27% 0.36 kB 0.45 kB +4.02% 0.20 kB 0.21 kB
oss-experimental/react-dom/server.node.js +17.12% 0.62 kB 0.73 kB +6.75% 0.25 kB 0.27 kB
oss-stable-semver/react-dom/server.node.js +17.12% 0.62 kB 0.73 kB +6.75% 0.25 kB 0.27 kB
oss-stable/react-dom/server.node.js +17.12% 0.62 kB 0.73 kB +6.75% 0.25 kB 0.27 kB
oss-experimental/react-dom/cjs/react-dom-server.node.production.js +3.26% 295.51 kB 305.15 kB +1.11% 52.54 kB 53.13 kB
oss-experimental/react-dom/cjs/react-dom-server.node.development.js +2.46% 447.51 kB 458.51 kB +0.81% 78.47 kB 79.11 kB
oss-stable-semver/react-dom/cjs/react-dom-server.node.production.js +2.41% 253.72 kB 259.84 kB +1.09% 45.98 kB 46.48 kB
oss-stable/react-dom/cjs/react-dom-server.node.production.js +2.41% 253.79 kB 259.92 kB +1.10% 46.01 kB 46.51 kB
oss-stable-semver/react-dom/cjs/react-dom-server.node.development.js +1.71% 402.08 kB 408.96 kB +0.77% 71.87 kB 72.42 kB
oss-stable/react-dom/cjs/react-dom-server.node.development.js +1.71% 402.15 kB 409.03 kB +0.77% 71.92 kB 72.47 kB

Generated by 🚫 dangerJS against 5457bb3

@sebmarkbage sebmarkbage merged commit 65ec57d into facebook:main Jun 7, 2025
247 checks passed
@unstubbable unstubbable mentioned this pull request Jun 7, 2025
Closed
@dsherret dsherret mentioned this pull request Jun 9, 2025
Closed
This was referenced Jun 9, 2025
Merged
Merged
Merged
Closed
@eps1lon eps1lon mentioned this pull request Jun 20, 2025
Merged
17 tasks
This was referenced Jun 23, 2025
Merged
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eps1lon eps1lon eps1lon approved these changes

@unstubbable unstubbable Awaiting requested review from unstubbable

Assignees
No one assigned
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sebmarkbage @react-sizebot @eps1lon @facebook-github-bot