Skip to content

[Flight] Add Web Stream support to the Flight Client in Node #33473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 6, 2025
Merged

[Flight] Add Web Stream support to the Flight Client in Node #33473

merged 1 commit into from
Jun 6, 2025
+8 −37

Conversation

sebmarkbage
Copy link
Collaborator

This effectively lets us consume Web Streams in a Node build. In fact the Node entry point is now just adding Node stream APIs.

For the client, this is simple because the configs are not actually stream type specific. The server is a little trickier.

@sebmarkbage
Re-export ReactFlightDOMClientEdge from ReactFlightDOMClientNode
95415b3 
This effectively lets us consume Web Streams in a Node build.
@sebmarkbage sebmarkbage changed the title Re-export ReactFlightDOMClientEdge from ReactFlightDOMClientNode [Flight] Add Web Stream support to the Flight Client in Node Jun 6, 2025
@github-actions github-actions bot added the React Core Team Opened by a member of the React Core Team label Jun 6, 2025
@react-sizebot
Copy link

Comparing: 82f3684...95415b3

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB +0.05% 1.83 kB 1.83 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 530.07 kB 530.07 kB = 93.57 kB 93.57 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB +0.05% 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 651.16 kB 651.16 kB = 114.70 kB 114.70 kB
facebook-www/ReactDOM-prod.classic.js = 676.11 kB 676.11 kB = 118.97 kB 118.97 kB
facebook-www/ReactDOM-prod.modern.js = 666.39 kB 666.39 kB = 117.36 kB 117.36 kB
oss-stable-semver/react-server-dom-parcel/cjs/react-server-dom-parcel-client.node.production.js +4.02% 54.66 kB 56.86 kB +3.51% 11.20 kB 11.60 kB
oss-stable/react-server-dom-parcel/cjs/react-server-dom-parcel-client.node.production.js +4.02% 54.66 kB 56.86 kB +3.51% 11.20 kB 11.60 kB
oss-experimental/react-server-dom-parcel/cjs/react-server-dom-parcel-client.node.production.js +3.98% 55.21 kB 57.41 kB +3.52% 11.29 kB 11.69 kB
oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.node.production.js +3.96% 57.73 kB 60.02 kB +3.58% 11.80 kB 12.22 kB
oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.node.production.js +3.96% 57.73 kB 60.02 kB +3.58% 11.80 kB 12.22 kB
oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.node.production.js +3.92% 58.28 kB 60.56 kB +3.56% 11.89 kB 12.31 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.unbundled.production.js +3.18% 60.24 kB 62.16 kB +3.12% 12.09 kB 12.47 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.unbundled.production.js +3.18% 60.24 kB 62.16 kB +3.12% 12.09 kB 12.47 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.unbundled.production.js +3.15% 60.77 kB 62.68 kB +3.13% 12.18 kB 12.56 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.production.js +3.12% 61.42 kB 63.33 kB +3.06% 12.33 kB 12.71 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.production.js +3.12% 61.42 kB 63.33 kB +3.06% 12.33 kB 12.71 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.production.js +3.09% 61.95 kB 63.86 kB +3.06% 12.42 kB 12.80 kB
oss-stable-semver/react-server-dom-parcel/cjs/react-server-dom-parcel-client.node.development.js +2.94% 103.29 kB 106.33 kB +2.44% 19.55 kB 20.02 kB
oss-stable/react-server-dom-parcel/cjs/react-server-dom-parcel-client.node.development.js +2.94% 103.29 kB 106.33 kB +2.44% 19.55 kB 20.02 kB
oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.node.development.js +2.65% 106.44 kB 109.26 kB +2.44% 20.04 kB 20.53 kB
oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.node.development.js +2.65% 106.44 kB 109.26 kB +2.44% 20.04 kB 20.53 kB
oss-experimental/react-server-dom-parcel/cjs/react-server-dom-parcel-client.node.development.js +2.56% 118.96 kB 122.00 kB +2.11% 22.38 kB 22.85 kB
oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.node.development.js +2.31% 122.11 kB 124.92 kB +2.07% 22.89 kB 23.36 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.unbundled.development.js +2.22% 109.18 kB 111.61 kB +2.23% 20.31 kB 20.76 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.unbundled.development.js +2.22% 109.18 kB 111.61 kB +2.23% 20.31 kB 20.76 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.development.js +2.20% 110.52 kB 112.94 kB +2.19% 20.56 kB 21.01 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.development.js +2.20% 110.52 kB 112.94 kB +2.19% 20.56 kB 21.01 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable-semver/react-server-dom-parcel/cjs/react-server-dom-parcel-client.node.production.js +4.02% 54.66 kB 56.86 kB +3.51% 11.20 kB 11.60 kB
oss-stable/react-server-dom-parcel/cjs/react-server-dom-parcel-client.node.production.js +4.02% 54.66 kB 56.86 kB +3.51% 11.20 kB 11.60 kB
oss-experimental/react-server-dom-parcel/cjs/react-server-dom-parcel-client.node.production.js +3.98% 55.21 kB 57.41 kB +3.52% 11.29 kB 11.69 kB
oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.node.production.js +3.96% 57.73 kB 60.02 kB +3.58% 11.80 kB 12.22 kB
oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.node.production.js +3.96% 57.73 kB 60.02 kB +3.58% 11.80 kB 12.22 kB
oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.node.production.js +3.92% 58.28 kB 60.56 kB +3.56% 11.89 kB 12.31 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.unbundled.production.js +3.18% 60.24 kB 62.16 kB +3.12% 12.09 kB 12.47 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.unbundled.production.js +3.18% 60.24 kB 62.16 kB +3.12% 12.09 kB 12.47 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.unbundled.production.js +3.15% 60.77 kB 62.68 kB +3.13% 12.18 kB 12.56 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.production.js +3.12% 61.42 kB 63.33 kB +3.06% 12.33 kB 12.71 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.production.js +3.12% 61.42 kB 63.33 kB +3.06% 12.33 kB 12.71 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.production.js +3.09% 61.95 kB 63.86 kB +3.06% 12.42 kB 12.80 kB
oss-stable-semver/react-server-dom-parcel/cjs/react-server-dom-parcel-client.node.development.js +2.94% 103.29 kB 106.33 kB +2.44% 19.55 kB 20.02 kB
oss-stable/react-server-dom-parcel/cjs/react-server-dom-parcel-client.node.development.js +2.94% 103.29 kB 106.33 kB +2.44% 19.55 kB 20.02 kB
oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.node.development.js +2.65% 106.44 kB 109.26 kB +2.44% 20.04 kB 20.53 kB
oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.node.development.js +2.65% 106.44 kB 109.26 kB +2.44% 20.04 kB 20.53 kB
oss-experimental/react-server-dom-parcel/cjs/react-server-dom-parcel-client.node.development.js +2.56% 118.96 kB 122.00 kB +2.11% 22.38 kB 22.85 kB
oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.node.development.js +2.31% 122.11 kB 124.92 kB +2.07% 22.89 kB 23.36 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.unbundled.development.js +2.22% 109.18 kB 111.61 kB +2.23% 20.31 kB 20.76 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.unbundled.development.js +2.22% 109.18 kB 111.61 kB +2.23% 20.31 kB 20.76 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.development.js +2.20% 110.52 kB 112.94 kB +2.19% 20.56 kB 21.01 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.development.js +2.20% 110.52 kB 112.94 kB +2.19% 20.56 kB 21.01 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.unbundled.development.js +1.94% 124.85 kB 127.28 kB +1.79% 23.19 kB 23.60 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.development.js +1.92% 126.18 kB 128.61 kB +1.77% 23.44 kB 23.86 kB

Generated by 🚫 dangerJS against 95415b3

@sebmarkbage sebmarkbage merged commit 280ff6f into facebook:main Jun 6, 2025
247 checks passed
This was referenced Jun 6, 2025
Merged
Merged
@eps1lon eps1lon mentioned this pull request Jun 20, 2025
Merged
17 tasks
This was referenced Jun 23, 2025
Merged
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@unstubbable unstubbable unstubbable approved these changes

@eps1lon eps1lon eps1lon approved these changes

Assignees
No one assigned
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sebmarkbage @react-sizebot @unstubbable @eps1lon @facebook-github-bot