[Flight] Build Node.js Web Streams builds for Turbopack and Parcel #33457
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
49bc9e2 to
5449539
Compare
5449539 to
aaa95aa
Compare
unstubbable
reviewed
Jun 6, 2025
| }; | ||
| exports.createServerReference = function (i, c, e, d, f) { | ||
| return w.registerServerReference( | ||
| n.createServerReference(i, c, e, d, f), |
There was a problem hiding this comment.
Only id and exportName are expected here, I think.
There was a problem hiding this comment.
This one's a bit different than the others though, because the second arg is actually exportName, and not callServer. Doesn't matter at runtime right now, but it's at least confusing.
unstubbable
approved these changes
Jun 6, 2025
sebmarkbage
added a commit
that referenced
this pull request
Jun 6, 2025
Reverts #33457, #33456 and #33442. There are too many issues with wrappers, lazy init, stateful modules, duplicate instantiation of async_hooks and duplication of code. Instead, we'll just do a wrapper polyfill that uses Node Streams internally. I kept the client indirection files that I added for consistency with the server though.
This was referenced Jun 6, 2025
17 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same as #33456 and #33442 but for Turbopack and Parcel.