Hide/unhide the content of dehydrated suspense boundaries if they resuspend #32900
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebmarkbage
commented
Apr 15, 2025
|
|
||
| expect(ref.current).toBe(null); | ||
| expect(span.style.display).toBe('none'); | ||
| expect(textNode.nodeValue).toBe(''); |
There was a problem hiding this comment.
What used to happen is that these weren't hidden. They remained visible.
sebmarkbage
commented
Apr 15, 2025
| } | ||
|
|
||
| function App({text, resuspend}) { | ||
| const memoized = React.useMemo(() => <Component text={text} />, [text]); |
There was a problem hiding this comment.
Memoization is important because otherwise the change in props due to the update can force a hydration.
8ef4af1 to
006e201
Compare
006e201 to
95e060f
Compare
sebmarkbage
commented
Apr 15, 2025
| if (node.nodeType === ELEMENT_NODE) { | ||
| const instance = ((node: any): HTMLElement & {_stashedDisplay?: string}); | ||
| if (isHidden) { | ||
| instance._stashedDisplay = instance.style.display; |
There was a problem hiding this comment.
We don't have the original props here yet since we haven't hydrated so we don't know what value to restore it to. So we stash the old value on an expando when we hide it. This is unfortunate but also it's just an edge case.
95e060f to
f661d4f
Compare
f661d4f to
ae9c0fd
Compare
|
Comparing: 539bbdb...ae9c0fd Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: Expand to show |
|
A possible alternative would be maybe to try to clear the boundary as if we're unable to hydrate it but we're not actually unable to hydrate content that was just temporarily hidden even though we might be unable to before it unsuspends. |
|
I think this is probably the right semantics if you also account for having to do a view transition on the dehydrated content. |
rickhanlonii
approved these changes
Apr 22, 2025
github-actions bot
pushed a commit
that referenced
this pull request
Apr 22, 2025
…uspend (#32900) Found this bug while working on Activity. There's a weird edge case when a dehydrated Suspense boundary is a direct child of another Suspense boundary which is hydrated but then it resuspends without forcing the inner one to hydrate/delete. It used to just leave that in place because hiding/unhiding didn't deal with dehydrated fragments. Not sure this is really worth fixing. DiffTrain build for [ebf7318](ebf7318)
github-actions bot
pushed a commit
that referenced
this pull request
Apr 22, 2025
…uspend (#32900) Found this bug while working on Activity. There's a weird edge case when a dehydrated Suspense boundary is a direct child of another Suspense boundary which is hydrated but then it resuspends without forcing the inner one to hydrate/delete. It used to just leave that in place because hiding/unhiding didn't deal with dehydrated fragments. Not sure this is really worth fixing. DiffTrain build for [ebf7318](ebf7318)
sebmarkbage
added a commit
that referenced
this pull request
Apr 22, 2025
Stacked on #32851 and #32900. This implements the equivalent Configs for ActivityInstance as we have for SuspenseInstance. These can be implemented as comments but they don't have to be and can be implemented differently in the renderer. This seems like a lot duplication but it's actually ends mostly just calling the same methods underneath and the wrappers compiles out. This doesn't leave the Activity dehydrated yet. It just hydrates into it immediately.
github-actions bot
pushed a commit
that referenced
this pull request
Apr 22, 2025
Stacked on #32851 and #32900. This implements the equivalent Configs for ActivityInstance as we have for SuspenseInstance. These can be implemented as comments but they don't have to be and can be implemented differently in the renderer. This seems like a lot duplication but it's actually ends mostly just calling the same methods underneath and the wrappers compiles out. This doesn't leave the Activity dehydrated yet. It just hydrates into it immediately. DiffTrain build for [17f88c8](17f88c8)
github-actions bot
pushed a commit
that referenced
this pull request
Apr 22, 2025
Stacked on #32851 and #32900. This implements the equivalent Configs for ActivityInstance as we have for SuspenseInstance. These can be implemented as comments but they don't have to be and can be implemented differently in the renderer. This seems like a lot duplication but it's actually ends mostly just calling the same methods underneath and the wrappers compiles out. This doesn't leave the Activity dehydrated yet. It just hydrates into it immediately. DiffTrain build for [17f88c8](17f88c8)
github-actions bot
pushed a commit
to code/lib-react
that referenced
this pull request
Apr 23, 2025
Stacked on facebook#32851 and facebook#32900. This implements the equivalent Configs for ActivityInstance as we have for SuspenseInstance. These can be implemented as comments but they don't have to be and can be implemented differently in the renderer. This seems like a lot duplication but it's actually ends mostly just calling the same methods underneath and the wrappers compiles out. This doesn't leave the Activity dehydrated yet. It just hydrates into it immediately. DiffTrain build for [17f88c8](facebook@17f88c8)
github-actions bot
pushed a commit
to code/lib-react
that referenced
this pull request
Apr 23, 2025
Stacked on facebook#32851 and facebook#32900. This implements the equivalent Configs for ActivityInstance as we have for SuspenseInstance. These can be implemented as comments but they don't have to be and can be implemented differently in the renderer. This seems like a lot duplication but it's actually ends mostly just calling the same methods underneath and the wrappers compiles out. This doesn't leave the Activity dehydrated yet. It just hydrates into it immediately. DiffTrain build for [17f88c8](facebook@17f88c8)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found this bug while working on Activity. There's a weird edge case when a dehydrated Suspense boundary is a direct child of another Suspense boundary which is hydrated but then it resuspends without forcing the inner one to hydrate/delete.
It used to just leave that in place because hiding/unhiding didn't deal with dehydrated fragments.
Not sure this is really worth fixing.