Move Built-in Props Types to React Types #32841
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Comparing: 31ecc98...bb01a3c Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: (No significant changes) |
rickhanlonii
approved these changes
Apr 10, 2025
| @@ -240,3 +235,78 @@ export type ReactTimeInfo = { | |||
| export type ReactDebugInfo = Array< | |||
| ReactComponentInfo | ReactEnvironmentInfo | ReactAsyncInfo | ReactTimeInfo, | |||
| >; | |||
|
|
|||
There was a problem hiding this comment.
I assume you're intentionally omitting LegacyHidden because deprecated, and doesn't need shared?
There was a problem hiding this comment.
Mainly I didn't see it implemented in Fizz originally. I see now that it's just part of the list of pass-throughs that just read children (along with Profiler) but we're not importing it into Fizz so was no reason to.
0e7a532 to
bb01a3c
Compare
github-actions bot
pushed a commit
that referenced
this pull request
Apr 10, 2025
Stacked on #32838. We don't always type the Props of built-ins. This adds typing for most of the built-ins. When we did type them, we used to put it in the `ReactFiber...Component` files but any public API like this can be implemented in other renderers too such as Fizz. So I moved them to `shared/ReactTypes` which is where we put other public API types (that are not already built-in to Flow). That way Fizz can import them and assert properly when it accesses the props. DiffTrain build for [c44e4a2](c44e4a2)
github-actions bot
pushed a commit
that referenced
this pull request
Apr 10, 2025
Stacked on #32838. We don't always type the Props of built-ins. This adds typing for most of the built-ins. When we did type them, we used to put it in the `ReactFiber...Component` files but any public API like this can be implemented in other renderers too such as Fizz. So I moved them to `shared/ReactTypes` which is where we put other public API types (that are not already built-in to Flow). That way Fizz can import them and assert properly when it accesses the props. DiffTrain build for [c44e4a2](c44e4a2)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stacked on #32838.
We don't always type the Props of built-ins. This adds typing for most of the built-ins.
When we did type them, we used to put it in the
ReactFiber...Componentfiles but any public API like this can be implemented in other renderers too such as Fizz. So I moved them toshared/ReactTypeswhich is where we put other public API types (that are not already built-in to Flow). That way Fizz can import them and assert properly when it accesses the props.