Skip to content

Send notification to Discord if automated publish fails #32840

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 9, 2025
Merged

Send notification to Discord if automated publish fails #32840

merged 1 commit into from
Apr 9, 2025

Conversation

eps1lon
Copy link
Collaborator

@eps1lon eps1lon commented Apr 9, 2025 •
edited
Loading

Summary

Only enabled for the nightly releases not manual releases to avoid spam in case of testing.

It's easy to miss if automated publish fails e.g. due to expired tokens. This will send a notification to the same channel PR notifications are sent.

How did you test this change?

yolo

@eps1lon eps1lon requested a review from poteto April 9, 2025 16:52
@github-actions github-actions bot added the React Core Team Opened by a member of the React Core Team label Apr 9, 2025
poteto
poteto approved these changes Apr 9, 2025
View reviewed changes
Copy link
Member

@poteto poteto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure why not

@react-sizebot
Copy link

Comparing: 7175841...226ba7e

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB = 1.83 kB 1.83 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 517.53 kB 516.15 kB = 92.06 kB 91.87 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB = 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 622.34 kB 619.52 kB = 110.13 kB 109.51 kB
facebook-www/ReactDOM-prod.classic.js = 655.25 kB 650.76 kB = 115.70 kB 114.94 kB
facebook-www/ReactDOM-prod.modern.js = 645.53 kB 641.04 kB = 114.15 kB 113.38 kB
oss-experimental/react-noop-renderer/cjs/react-noop-renderer-server.development.js = 7.63 kB 7.31 kB = 1.63 kB 1.59 kB
oss-stable-semver/react-noop-renderer/cjs/react-noop-renderer-server.development.js = 7.63 kB 7.31 kB = 1.63 kB 1.59 kB
oss-stable/react-noop-renderer/cjs/react-noop-renderer-server.development.js = 7.63 kB 7.31 kB = 1.63 kB 1.59 kB
oss-experimental/react-noop-renderer/cjs/react-noop-renderer-server.production.js = 6.34 kB 6.05 kB = 1.55 kB 1.52 kB
oss-stable-semver/react-noop-renderer/cjs/react-noop-renderer-server.production.js = 6.34 kB 6.05 kB = 1.55 kB 1.52 kB
oss-stable/react-noop-renderer/cjs/react-noop-renderer-server.production.js = 6.34 kB 6.05 kB = 1.55 kB 1.52 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom-profiling.development.js = 973.69 kB 971.71 kB = 164.05 kB 163.82 kB
oss-stable-semver/react-dom/cjs/react-dom-profiling.development.js = 973.57 kB 971.58 kB = 164.02 kB 163.79 kB
oss-stable/react-dom/cjs/react-dom-client.development.js = 957.25 kB 955.27 kB = 161.20 kB 160.97 kB
oss-stable-semver/react-dom/cjs/react-dom-client.development.js = 957.13 kB 955.14 kB = 161.17 kB 160.94 kB
facebook-react-native/react-dom/cjs/ReactDOMProfiling-profiling.js = 574.21 kB 572.98 kB = 101.01 kB 100.81 kB
facebook-react-native/react-dom/cjs/ReactDOMClient-profiling.js = 568.27 kB 567.04 kB = 99.85 kB 99.66 kB
facebook-react-native/react-dom/cjs/ReactDOMProfiling-prod.js = 546.61 kB 545.34 kB = 97.03 kB 96.83 kB
facebook-react-native/react-dom/cjs/ReactDOMClient-prod.js = 541.10 kB 539.84 kB = 95.95 kB 95.76 kB
oss-stable/react-dom/cjs/react-dom-profiling.profiling.js = 550.19 kB 548.86 kB = 96.92 kB 96.72 kB
oss-stable-semver/react-dom/cjs/react-dom-profiling.profiling.js = 550.07 kB 548.74 kB = 96.89 kB 96.70 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 517.53 kB 516.15 kB = 92.06 kB 91.87 kB
oss-stable-semver/react-dom/cjs/react-dom-client.production.js = 517.40 kB 516.03 kB = 92.03 kB 91.85 kB
facebook-www/ReactDOMServerStreaming-prod.modern.js = 224.54 kB 223.89 kB = 41.26 kB 41.16 kB
oss-stable/react-dom/cjs/react-dom-server.bun.production.js = 216.11 kB 215.46 kB = 39.79 kB 39.70 kB
oss-stable-semver/react-dom/cjs/react-dom-server.bun.production.js = 216.04 kB 215.39 kB = 39.77 kB 39.67 kB
facebook-www/ReactDOMServerStreaming-dev.modern.js = 368.32 kB 367.20 kB = 66.20 kB 66.05 kB
oss-stable/react-dom/cjs/react-dom-server.bun.development.js = 323.73 kB 322.72 kB = 62.92 kB 62.76 kB
oss-stable-semver/react-dom/cjs/react-dom-server.bun.development.js = 323.66 kB 322.64 kB = 62.89 kB 62.73 kB
facebook-www/ReactDOMServer-dev.classic.js = 380.13 kB 378.85 kB = 68.10 kB 67.90 kB
oss-stable/react-dom/cjs/react-dom-server.node.development.js = 375.89 kB 374.62 kB = 67.58 kB 67.38 kB
oss-stable-semver/react-dom/cjs/react-dom-server.node.development.js = 375.82 kB 374.55 kB = 67.52 kB 67.33 kB
oss-stable/react-dom/cjs/react-dom-server.edge.development.js = 380.15 kB 378.87 kB = 68.35 kB 68.15 kB
oss-stable-semver/react-dom/cjs/react-dom-server.edge.development.js = 380.08 kB 378.79 kB = 68.30 kB 68.10 kB
oss-stable/react-dom/cjs/react-dom-server.browser.development.js = 379.37 kB 378.09 kB = 68.20 kB 68.00 kB
oss-stable-semver/react-dom/cjs/react-dom-server.browser.development.js = 379.29 kB 378.01 kB = 68.15 kB 67.95 kB
facebook-www/ReactDOMServer-dev.modern.js = 376.67 kB 375.40 kB = 67.56 kB 67.36 kB
oss-stable/react-dom/cjs/react-dom-server-legacy.browser.development.js = 363.63 kB 362.36 kB = 66.04 kB 65.84 kB
oss-stable/react-dom/cjs/react-dom-server-legacy.node.development.js = 363.63 kB 362.35 kB = 66.04 kB 65.84 kB
oss-stable-semver/react-dom/cjs/react-dom-server-legacy.browser.development.js = 363.61 kB 362.33 kB = 66.01 kB 65.82 kB
oss-stable-semver/react-dom/cjs/react-dom-server-legacy.node.development.js = 363.61 kB 362.33 kB = 66.01 kB 65.82 kB
facebook-www/ReactDOMServer-prod.classic.js = 222.91 kB 222.11 kB = 40.02 kB 39.89 kB
facebook-www/ReactDOMServer-prod.modern.js = 220.22 kB 219.43 kB = 39.69 kB 39.56 kB
oss-stable/react-dom/cjs/react-dom-server-legacy.node.production.js = 216.31 kB 215.52 kB = 40.36 kB 40.24 kB
oss-stable-semver/react-dom/cjs/react-dom-server-legacy.node.production.js = 216.28 kB 215.49 kB = 40.33 kB 40.21 kB
oss-stable/react-dom/cjs/react-dom-server-legacy.browser.production.js = 211.79 kB 211.00 kB = 38.59 kB 38.46 kB
oss-stable-semver/react-dom/cjs/react-dom-server-legacy.browser.production.js = 211.77 kB 210.98 kB = 38.57 kB 38.43 kB
oss-stable/react-dom/cjs/react-dom-server.node.production.js = 232.81 kB 231.86 kB = 42.32 kB 42.16 kB
oss-stable-semver/react-dom/cjs/react-dom-server.node.production.js = 232.73 kB 231.79 kB = 42.29 kB 42.14 kB
oss-stable/react-dom/cjs/react-dom-server.edge.production.js = 236.29 kB 235.33 kB = 43.32 kB 43.16 kB
oss-stable-semver/react-dom/cjs/react-dom-server.edge.production.js = 236.22 kB 235.26 kB = 43.30 kB 43.14 kB
oss-experimental/react-markup/cjs/react-markup.react-server.development.js = 535.35 kB 533.16 kB = 95.97 kB 95.52 kB
oss-stable/react-dom/cjs/react-dom-server.browser.production.js = 231.10 kB 230.14 kB = 41.37 kB 41.18 kB
oss-stable-semver/react-dom/cjs/react-dom-server.browser.production.js = 231.02 kB 230.06 kB = 41.35 kB 41.16 kB
oss-experimental/react-dom/cjs/react-dom-profiling.profiling.js = 687.12 kB 684.23 kB = 119.92 kB 119.30 kB
oss-experimental/react-dom/cjs/react-dom-unstable_testing.production.js = 636.75 kB 633.93 kB = 113.71 kB 113.10 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 622.34 kB 619.52 kB = 110.13 kB 109.51 kB
oss-experimental/react-server/cjs/react-server.development.js = 189.41 kB 188.44 kB = 33.08 kB 32.94 kB
oss-experimental/react/cjs/react.react-server.production.js = 18.86 kB 18.76 kB = 5.00 kB 4.97 kB
oss-experimental/react-markup/cjs/react-markup.react-server.production.js = 318.60 kB 316.84 kB = 59.55 kB 59.14 kB
oss-stable-semver/react-server/cjs/react-server.development.js = 172.71 kB 171.74 kB = 31.03 kB 30.89 kB
oss-stable/react-server/cjs/react-server.development.js = 172.71 kB 171.74 kB = 31.03 kB 30.89 kB
facebook-www/ReactDOMTesting-dev.classic.js = 1,208.86 kB 1,201.95 kB = 201.78 kB 200.61 kB
facebook-www/ReactDOMTesting-dev.modern.js = 1,199.72 kB 1,192.81 kB = 200.08 kB 198.83 kB
facebook-www/ReactDOM-dev.classic.js = 1,192.33 kB 1,185.42 kB = 198.01 kB 196.82 kB
facebook-www/ReactDOM-dev.modern.js = 1,183.19 kB 1,176.28 kB = 196.24 kB 195.05 kB
oss-experimental/react-markup/cjs/react-markup.development.js = 360.59 kB 358.40 kB = 64.75 kB 64.29 kB
facebook-www/ReactDOM-profiling.classic.js = 727.34 kB 722.82 kB = 125.75 kB 125.00 kB
oss-experimental/react-server/cjs/react-server.production.js = 130.36 kB 129.54 kB = 22.64 kB 22.52 kB
facebook-www/ReactDOM-profiling.modern.js = 719.30 kB 714.78 kB = 124.42 kB 123.68 kB
oss-experimental/react-dom/cjs/react-dom-server.bun.development.js = 348.64 kB 346.33 kB = 66.23 kB 65.66 kB
oss-experimental/react-dom/cjs/react-dom-server.node.development.js = 411.50 kB 408.75 kB = 71.59 kB 71.04 kB
facebook-www/ReactDOMTesting-prod.classic.js = 669.65 kB 665.16 kB = 119.38 kB 118.61 kB
oss-experimental/react-dom/cjs/react-dom-server.browser.development.js = 415.61 kB 412.81 kB = 72.17 kB 71.59 kB
facebook-www/ReactDOMTesting-prod.modern.js = 659.93 kB 655.44 kB = 117.75 kB 116.98 kB
facebook-www/ReactDOM-prod.classic.js = 655.25 kB 650.76 kB = 115.70 kB 114.94 kB
facebook-www/ReactDOM-prod.modern.js = 645.53 kB 641.04 kB = 114.15 kB 113.38 kB
oss-stable-semver/react-server/cjs/react-server.production.js = 116.31 kB 115.50 kB = 20.77 kB 20.64 kB
oss-stable/react-server/cjs/react-server.production.js = 116.31 kB 115.50 kB = 20.77 kB 20.64 kB
oss-experimental/react-dom/cjs/react-dom-server.edge.development.js = 416.62 kB 413.59 kB = 72.40 kB 71.77 kB
oss-experimental/react-dom/cjs/react-dom-unstable_testing.development.js = 1,146.22 kB 1,137.90 kB = 192.18 kB 190.54 kB
oss-experimental/react-dom/cjs/react-dom-profiling.development.js = 1,146.07 kB 1,137.75 kB = 191.34 kB 189.68 kB
oss-experimental/react-dom/cjs/react-dom-client.development.js = 1,129.68 kB 1,121.36 kB = 188.50 kB 186.85 kB
oss-experimental/react-dom/cjs/react-dom-server-legacy.browser.development.js = 390.60 kB 387.63 kB = 69.31 kB 68.74 kB
oss-experimental/react-dom/cjs/react-dom-server-legacy.node.development.js = 390.60 kB 387.63 kB = 69.31 kB 68.74 kB
oss-experimental/react-dom/cjs/react-dom-server.bun.production.js = 236.70 kB 234.81 kB = 42.57 kB 42.12 kB
test_utils/ReactAllWarnings.js = 65.59 kB 65.07 kB = 16.47 kB 16.28 kB
oss-experimental/react-markup/cjs/react-markup.production.js = 218.28 kB 216.52 kB = 40.31 kB 39.89 kB
oss-experimental/react-dom/cjs/react-dom-server.node.production.js = 260.54 kB 258.30 kB = 45.89 kB 45.39 kB
oss-experimental/react-dom/cjs/react-dom-server.browser.production.js = 258.78 kB 256.50 kB = 44.74 kB 44.24 kB
oss-experimental/react-dom/cjs/react-dom-server-legacy.node.production.js = 236.07 kB 233.88 kB = 43.16 kB 42.66 kB
oss-experimental/react-dom/cjs/react-dom-server.edge.production.js = 264.72 kB 262.26 kB = 46.90 kB 46.32 kB
oss-experimental/react-dom/cjs/react-dom-server-legacy.browser.production.js = 230.99 kB 228.80 kB = 41.26 kB 40.74 kB
oss-experimental/react-noop-renderer/cjs/react-noop-renderer-server.development.js = 7.63 kB 7.31 kB = 1.63 kB 1.59 kB
oss-stable-semver/react-noop-renderer/cjs/react-noop-renderer-server.development.js = 7.63 kB 7.31 kB = 1.63 kB 1.59 kB
oss-stable/react-noop-renderer/cjs/react-noop-renderer-server.development.js = 7.63 kB 7.31 kB = 1.63 kB 1.59 kB
oss-experimental/react-noop-renderer/cjs/react-noop-renderer-server.production.js = 6.34 kB 6.05 kB = 1.55 kB 1.52 kB
oss-stable-semver/react-noop-renderer/cjs/react-noop-renderer-server.production.js = 6.34 kB 6.05 kB = 1.55 kB 1.52 kB
oss-stable/react-noop-renderer/cjs/react-noop-renderer-server.production.js = 6.34 kB 6.05 kB = 1.55 kB 1.52 kB

Generated by 🚫 dangerJS against 226ba7e

@eps1lon eps1lon changed the title Sent notification to Discord if automated publish fails Send notification to Discord if automated publish fails Apr 9, 2025
@eps1lon eps1lon merged commit 096dd73 into facebook:main Apr 9, 2025
243 checks passed
@eps1lon eps1lon deleted the sebbie/publish-failure-notify branch April 9, 2025 17:15
github-actions bot pushed a commit that referenced this pull request Apr 9, 2025
@eps1lon
Send notification to Discord if automated publish fails (#32840)
7857e82 
DiffTrain build for [096dd73](096dd73)
@vercel-release-bot vercel-release-bot mentioned this pull request Apr 10, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@poteto poteto poteto approved these changes

Assignees
No one assigned
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@eps1lon @react-sizebot @poteto @facebook-github-bot