Skip to content

[eprh] Temporarily disable ref access in render validation #32839

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 9, 2025
Merged

[eprh] Temporarily disable ref access in render validation #32839

merged 1 commit into from
Apr 9, 2025

Conversation

poteto
Copy link
Member

@poteto poteto commented Apr 9, 2025

This rule currently has a few false positives, so let's disable it for now (just in the eslint rule, it's still enabled in the compiler) while we iterate on it.

@github-actions github-actions bot added the React Core Team Opened by a member of the React Core Team label Apr 9, 2025
@react-sizebot
Copy link

react-sizebot commented Apr 9, 2025 •
edited
Loading

Comparing: 096dd73...0b39c1f

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB = 1.83 kB 1.83 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 517.53 kB 517.53 kB = 92.06 kB 92.06 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB = 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 622.34 kB 622.34 kB = 110.13 kB 110.13 kB
facebook-www/ReactDOM-prod.classic.js = 655.25 kB 655.25 kB = 115.70 kB 115.70 kB
facebook-www/ReactDOM-prod.modern.js = 645.53 kB 645.53 kB = 114.15 kB 114.15 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against 0b39c1f

@poteto
[eprh] Temporarily disable ref access in render validation
0b39c1f 
This rule currently has a few false positives, so let's disable it for now (just in the eslint rule, it's still enabled in the compiler) while we iterate on it.
@poteto poteto merged commit ff697fc into main Apr 9, 2025
481 of 485 checks passed
@poteto poteto deleted the pr32839 branch April 9, 2025 18:49
github-actions bot pushed a commit that referenced this pull request Apr 9, 2025
@poteto
[eprh] Temporarily disable ref access in render validation (#32839)
402cf9f 
This rule currently has a few false positives, so let's disable it for
now (just in the eslint rule, it's still enabled in the compiler) while
we iterate on it.

DiffTrain build for [ff697fc](ff697fc)
@vercel-release-bot vercel-release-bot mentioned this pull request Apr 10, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@poteto @react-sizebot @facebook-github-bot