Warn for duplicate ViewTransition names #32752
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebmarkbage
commented
Mar 26, 2025
| untrackNamedViewTransition(deletedFiber); | ||
| } | ||
| } | ||
| safelyDetachRef(deletedFiber, nearestMountedAncestor); |
There was a problem hiding this comment.
I also noticed that we weren't detaching ViewTransition refs when unmounting. Only hiding.
sebmarkbage
commented
Mar 26, 2025
| nearestMountedAncestor, | ||
| deletedFiber, | ||
| ); | ||
| return; |
There was a problem hiding this comment.
This can safe some bytes by falling through but it really only works for one case and it's easy to get wrong when copying it so I made this explicit.
|
Comparing: 4845e16...78a6542 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: Expand to show
|
| }); | ||
| runWithFiberInDEV(existing, () => { | ||
| console.error( | ||
| 'The existing <ViewTransition name=%s> duplicate has this stack trace.', |
There was a problem hiding this comment.
I don't know how to phrase this so it's not to repetitive when shown together but also somewhat makes sense in isolation if they're show independently. This log entry has the other Fiber's owner/async stack trace. I think we have this pattern of two logs somewhere else.
There was a problem hiding this comment.
Oh, you're logging the other component stack. Might be weird to see this in places where the component stack is less visible/collapsed? Could we add the owner component name?
There was a problem hiding this comment.
The existing
<ViewTransition name=%s>duplicate rendered inParent.
rickhanlonii
approved these changes
Mar 26, 2025
github-actions bot
pushed a commit
that referenced
this pull request
Mar 26, 2025
This adds early logging when two ViewTransitions with the same name are mounted at the same time. Whether they're part of a View Transition or not. This lets us include the owner stack of each one. I do two logs so that you can get the stack trace of each one of the duplicates. It currently only logs once for each name which also avoids the scenario when you have many hits for the same name in one commit. However, we could also possibly log a stack for each of them but seems noisy. Currently we don't log if a SwipeTransition is the first time the pair gets mounted which could lead to a View Transition error before we've warned. That could be a separate improvement. DiffTrain build for [8ac25e5](8ac25e5)
eps1lon
pushed a commit
to vercel/next.js
that referenced
this pull request
Mar 26, 2025
[diff facebook/react@740a4f7a...313332d1](facebook/react@740a4f7...313332d) <details> <summary>React upstream changes</summary> - facebook/react#32741 - facebook/react#32726 - facebook/react#32752 - facebook/react#32749 - facebook/react#32748 - facebook/react#32746 </details>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds early logging when two ViewTransitions with the same name are mounted at the same time. Whether they're part of a View Transition or not.
This lets us include the owner stack of each one. I do two logs so that you can get the stack trace of each one of the duplicates.
It currently only logs once for each name which also avoids the scenario when you have many hits for the same name in one commit. However, we could also possibly log a stack for each of them but seems noisy.
Currently we don't log if a SwipeTransition is the first time the pair gets mounted which could lead to a View Transition error before we've warned. That could be a separate improvement.