Skip to content

Remove offscreen type #32639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 17, 2025
Merged

Remove offscreen type #32639

merged 3 commits into from
Mar 17, 2025

Conversation

rickhanlonii
Copy link
Member

Based off #32499

This is no longer used.

Review commit

@rickhanlonii rickhanlonii mentioned this pull request Mar 16, 2025
Merged
@github-actions github-actions bot added the React Core Team Opened by a member of the React Core Team label Mar 16, 2025
@react-sizebot
Copy link

react-sizebot commented Mar 16, 2025 •
edited
Loading

Comparing: 1a19170...fa0160a

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB +0.05% 1.83 kB 1.83 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 517.50 kB 517.29 kB = 92.31 kB 92.26 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB +0.05% 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 605.76 kB 605.54 kB = 107.47 kB 107.43 kB
facebook-www/ReactDOM-prod.classic.js = 651.19 kB 650.98 kB = 114.72 kB 114.69 kB
facebook-www/ReactDOM-prod.modern.js = 641.47 kB 641.26 kB = 113.14 kB 113.10 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
oss-experimental/react/cjs/react.development.js = 47.11 kB 47.01 kB = 10.68 kB 10.65 kB
oss-stable/react/cjs/react.development.js = 45.37 kB 45.27 kB = 10.32 kB 10.29 kB
oss-stable-semver/react/cjs/react.development.js = 45.34 kB 45.24 kB = 10.29 kB 10.26 kB
oss-experimental/react/cjs/react.react-server.development.js = 36.06 kB 35.96 kB = 8.51 kB 8.49 kB
oss-stable/react/cjs/react.react-server.development.js = 29.02 kB 28.92 kB = 6.97 kB 6.95 kB
oss-stable-semver/react/cjs/react.react-server.development.js = 29.00 kB 28.90 kB = 6.95 kB 6.92 kB
facebook-www/ReactIs-dev.classic.js = 6.69 kB 6.58 kB = 1.44 kB 1.42 kB
facebook-www/ReactIs-dev.modern.js = 6.69 kB 6.58 kB = 1.44 kB 1.42 kB
facebook-www/ReactIs-prod.classic.js = 6.08 kB 5.98 kB = 1.41 kB 1.39 kB
facebook-www/ReactIs-prod.modern.js = 6.08 kB 5.98 kB = 1.41 kB 1.39 kB
facebook-react-native/react-is/cjs/ReactIs-dev.js = 5.41 kB 5.31 kB = 1.22 kB 1.20 kB
facebook-react-native/react-is/cjs/ReactIs-prod.js = 4.86 kB 4.77 kB = 1.19 kB 1.17 kB
facebook-react-native/react-is/cjs/ReactIs-profiling.js = 4.86 kB 4.77 kB = 1.19 kB 1.17 kB
oss-experimental/react-is/cjs/react-is.development.js = 5.26 kB 5.16 kB = 1.18 kB 1.15 kB
oss-stable-semver/react-is/cjs/react-is.development.js = 5.22 kB 5.12 kB = 1.17 kB 1.15 kB
oss-stable/react-is/cjs/react-is.development.js = 5.22 kB 5.12 kB = 1.17 kB 1.15 kB
oss-experimental/react-is/cjs/react-is.production.js = 4.70 kB 4.61 kB = 1.13 kB 1.10 kB
oss-stable-semver/react-is/cjs/react-is.production.js = 4.66 kB 4.56 kB = 1.12 kB 1.10 kB
oss-stable/react-is/cjs/react-is.production.js = 4.66 kB 4.56 kB = 1.12 kB 1.10 kB

Generated by 🚫 dangerJS against 53fe6c1

@rickhanlonii rickhanlonii force-pushed the rh/remove-offscreen-type branch from 88c297d to 53fe6c1 Compare March 17, 2025 13:28
@rickhanlonii rickhanlonii merged commit df31952 into facebook:main Mar 17, 2025
194 checks passed
github-actions bot pushed a commit that referenced this pull request Mar 17, 2025
@rickhanlonii
Remove offscreen type (#32639)
58d48f5 
Based off #32499

This is no longer used.

[Review
commit](88c297d)

DiffTrain build for [df31952](df31952)
github-actions bot pushed a commit that referenced this pull request Mar 17, 2025
@rickhanlonii
Remove offscreen type (#32639)
0c39221 
Based off #32499

This is no longer used.

[Review
commit](88c297d)

DiffTrain build for [df31952](df31952)
This was referenced Mar 17, 2025
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebmarkbage sebmarkbage sebmarkbage approved these changes

Assignees
No one assigned
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rickhanlonii @react-sizebot @sebmarkbage @facebook-github-bot