Skip to content

Make renameElementSymbol dynamic for native fb #32566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 10, 2025
Merged

Make renameElementSymbol dynamic for native fb #32566

merged 1 commit into from
Mar 10, 2025

Conversation

jackpope
Copy link
Member

Use variant to begin rolling this out internally.

@github-actions github-actions bot added the React Core Team Opened by a member of the React Core Team label Mar 10, 2025
@react-sizebot
Copy link

Comparing: d331ba0...6b3db2c

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB +0.05% 1.83 kB 1.83 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 518.54 kB 518.54 kB = 92.45 kB 92.45 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB = 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 589.31 kB 589.31 kB = 104.91 kB 104.91 kB
facebook-www/ReactDOM-prod.classic.js = 642.76 kB 642.76 kB = 113.01 kB 113.01 kB
facebook-www/ReactDOM-prod.modern.js = 633.08 kB 633.08 kB = 111.44 kB 111.44 kB
facebook-react-native/react/cjs/JSXRuntime-prod.js +21.60% 0.96 kB 1.17 kB +13.85% 0.49 kB 0.56 kB
facebook-react-native/react/cjs/JSXRuntime-profiling.js +21.60% 0.96 kB 1.17 kB +13.85% 0.49 kB 0.56 kB
facebook-react-native/react-is/cjs/ReactIs-dev.js +4.77% 5.07 kB 5.31 kB +6.47% 1.13 kB 1.20 kB
facebook-react-native/react-is/cjs/ReactIs-prod.js +4.24% 4.58 kB 4.77 kB +6.27% 1.10 kB 1.17 kB
facebook-react-native/react-is/cjs/ReactIs-profiling.js +4.24% 4.58 kB 4.77 kB +6.27% 1.10 kB 1.17 kB
facebook-react-native/react/cjs/JSXDEVRuntime-dev.js +2.56% 11.06 kB 11.34 kB +2.74% 3.07 kB 3.15 kB
facebook-react-native/react/cjs/JSXRuntime-dev.js +2.51% 11.26 kB 11.54 kB +2.69% 3.09 kB 3.17 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
facebook-react-native/react/cjs/JSXRuntime-prod.js +21.60% 0.96 kB 1.17 kB +13.85% 0.49 kB 0.56 kB
facebook-react-native/react/cjs/JSXRuntime-profiling.js +21.60% 0.96 kB 1.17 kB +13.85% 0.49 kB 0.56 kB
facebook-react-native/react-is/cjs/ReactIs-dev.js +4.77% 5.07 kB 5.31 kB +6.47% 1.13 kB 1.20 kB
facebook-react-native/react-is/cjs/ReactIs-prod.js +4.24% 4.58 kB 4.77 kB +6.27% 1.10 kB 1.17 kB
facebook-react-native/react-is/cjs/ReactIs-profiling.js +4.24% 4.58 kB 4.77 kB +6.27% 1.10 kB 1.17 kB
facebook-react-native/react/cjs/JSXDEVRuntime-dev.js +2.56% 11.06 kB 11.34 kB +2.74% 3.07 kB 3.15 kB
facebook-react-native/react/cjs/JSXRuntime-dev.js +2.51% 11.26 kB 11.54 kB +2.69% 3.09 kB 3.17 kB
facebook-react-native/react/cjs/React-prod.js +1.07% 19.52 kB 19.73 kB +1.06% 5.08 kB 5.13 kB
facebook-react-native/react/cjs/React-profiling.js +1.04% 19.95 kB 20.16 kB +1.03% 5.16 kB 5.21 kB
facebook-react-native/react/cjs/React-dev.js +0.35% 51.03 kB 51.21 kB +0.46% 11.36 kB 11.41 kB

Generated by 🚫 dangerJS against c207650

rickhanlonii
rickhanlonii approved these changes Mar 10, 2025
View reviewed changes
Copy link
Member

@rickhanlonii rickhanlonii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hells ya

@jackpope jackpope merged commit 50ab2dd into facebook:main Mar 10, 2025
196 checks passed
@jackpope jackpope deleted the renameelementsymbol-fb-rn branch March 10, 2025 19:24
github-actions bot pushed a commit that referenced this pull request Mar 10, 2025
@jackpope
Make renameElementSymbol dynamic for native fb (#32566)
64aba73 
Use variant to begin rolling this out internally.

DiffTrain build for [50ab2dd](50ab2dd)
@vercel-release-bot vercel-release-bot mentioned this pull request Mar 11, 2025
Merged
huozhi pushed a commit to vercel/next.js that referenced this pull request Mar 11, 2025
@vercel-release-bot
Upgrade React from 029e8bd6-20250306 to 0ca3deeb-20250311 (#76989)
808934a 
[diff
facebook/react@029e8bd6...0ca3deeb](facebook/react@029e8bd...0ca3dee)

<details>
<summary>React upstream changes</summary>

- facebook/react#32569
- facebook/react#32567
- facebook/react#32549
- facebook/react#32545
- facebook/react#32566
- facebook/react#32551
- facebook/react#32550
- facebook/react#32528
- facebook/react#32359
- facebook/react#32536
- facebook/react#32539

</details>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rickhanlonii rickhanlonii rickhanlonii approved these changes

@yungsters yungsters Awaiting requested review from yungsters

@rubennorte rubennorte Awaiting requested review from rubennorte

Assignees
No one assigned
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jackpope @react-sizebot @rickhanlonii @facebook-github-bot