You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is a feature that syncs the element selection between Elements panel and RDT Components panel.
Before this change, after the scrollToItem is called, user is going to see the empty list, because nothing is rendered. This is because AutoSizer doesn't know anything about FixedSizeList and that it was just scrolled.
With this change, we are using selectedItemIndex to force re-render for AutoSizer, which will consequently call children function.
not sure if this has anything to do with the issue you're fixing, but wanted to note it's pretty frustrating that the first time I open the Components tab, its scroll position isn't synced to the DOM selection — so i have to "find" the element again. i beileve this used to work in the distant past
not sure if this has anything to do with the issue you're fixing, but wanted to note it's pretty frustrating that the first time I open the Components tab, its scroll position isn't synced to the DOM selection — so i have to "find" the element again. i beileve this used to work in the distant past
Yeah, this is one of the things I am fixing. I am currently on leave, but planning to get this fixed once I am back in December.
Related: #31342
This fixes RDT behaviour when some DOM element was pre-selected in
built-in browser's Elements panel, and then Components panel of React
DevTools was opened for the first time. With this change, React DevTools
will correctly display the initial state of the Components Tree with the
corresponding React Element (if possible) pre-selected.
Previously, we would only subscribe listener when `TreeContext` is
mounted, but this only happens when user opens one of React DevTools
panels for the first time. With this change, we keep state inside
`Store`, which is created when Browser DevTools are opened. Later,
`TreeContext` will use it for initial state value.
Planned next changes:
1. Merge `inspectedElementID` and `selectedElementID`, I have no idea
why we need both.
2. Fix issue with `AutoSizer` rendering a blank container.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is a feature that syncs the element selection between Elements panel and RDT Components panel.
Before this change, after the
scrollToItemis called, user is going to see the empty list, because nothing is rendered. This is becauseAutoSizerdoesn't know anything aboutFixedSizeListand that it was just scrolled.With this change, we are using
selectedItemIndexto force re-render forAutoSizer, which will consequently call children function.See https://fburl.com/workplace/gnu43nok.