Skip to content

[rcr] Remove runtimeModule compiler option #31145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 23 commits into from
Oct 7, 2024
Merged

[rcr] Remove runtimeModule compiler option #31145

merged 23 commits into from
Oct 7, 2024

Conversation

poteto
Copy link
Member

@poteto poteto commented Oct 7, 2024

Now that the compiler always injects react-compiler-runtime, this
option is unnecessary.

poteto added 7 commits October 7, 2024 15:18
@poteto
Update
443a9a3 
[ghstack-poisoned]
@poteto
Update
0f22b5b 
[ghstack-poisoned]
@poteto
Update
491db33 
[ghstack-poisoned]
@poteto
Update
38f70e3 
[ghstack-poisoned]
@poteto
Update
871b2a3 
[ghstack-poisoned]
@poteto
Update
1827773 
[ghstack-poisoned]
@poteto
Update
7d312db 
[ghstack-poisoned]
@poteto
Copy link
Member Author

poteto commented Oct 7, 2024 •
edited
Loading

Stack from ghstack (oldest at bottom):

@poteto poteto mentioned this pull request Oct 7, 2024
Merged
@vercel Vercel
Copy link

vercel bot commented Oct 7, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-compiler-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 7, 2024 10:01pm

This was referenced Oct 7, 2024
Merged
Merged
Merged
Merged
Merged
poteto added a commit that referenced this pull request Oct 7, 2024
@poteto
[rcr] Remove runtimeModule compiler option
d413974 
Now that the compiler always injects `react-compiler-runtime`, this
option is unnecessary.

ghstack-source-id: 8141f6d
ghstack-comment-id: 2397700297
Pull Request resolved: #31145
@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Oct 7, 2024
poteto added 4 commits October 7, 2024 15:20
@poteto
Update
5e7d542 
[ghstack-poisoned]
@poteto
Update
dc74437 
[ghstack-poisoned]
@poteto
Update
378d4a6 
[ghstack-poisoned]
@poteto
Update
c1f90d9 
[ghstack-poisoned]
poteto added a commit that referenced this pull request Oct 7, 2024
@poteto
[rcr] Remove runtimeModule compiler option
beb2799 
Now that the compiler always injects `react-compiler-runtime`, this
option is unnecessary.

ghstack-source-id: 8141f6d
ghstack-comment-id: 2397700297
Pull Request resolved: #31145
poteto added 3 commits October 7, 2024 15:22
@poteto
Update
51489ab 
[ghstack-poisoned]
@poteto
Update
4885d53 
[ghstack-poisoned]
@poteto
Update
e3a8e06 
[ghstack-poisoned]
poteto added a commit that referenced this pull request Oct 7, 2024
@poteto
[rcr] Remove runtimeModule compiler option
52d2c55 
Now that the compiler always injects `react-compiler-runtime`, this
option is unnecessary.

ghstack-source-id: ec5ff3e
ghstack-comment-id: 2397700297
Pull Request resolved: #31145
poteto added 2 commits October 7, 2024 15:30
@poteto
Update
7d79cf6 
[ghstack-poisoned]
@poteto
Update
892c825 
[ghstack-poisoned]
poteto added a commit that referenced this pull request Oct 7, 2024
@poteto
[rcr] Remove runtimeModule compiler option
6fdb95b 
Now that the compiler always injects `react-compiler-runtime`, this
option is unnecessary.

ghstack-source-id: 6ad6822
ghstack-comment-id: 2397700297
Pull Request resolved: #31145
poteto added 6 commits October 7, 2024 16:25
@poteto
Update
79468bd 
[ghstack-poisoned]
@poteto
Update
f8342cb 
[ghstack-poisoned]
@poteto
Update
2236fb7 
[ghstack-poisoned]
@poteto
Update
8352c1e 
[ghstack-poisoned]
@poteto
Update
0d8cf4b 
[ghstack-poisoned]
@poteto
Update
4e62f10 
[ghstack-poisoned]
poteto added a commit that referenced this pull request Oct 7, 2024
@poteto
[rcr] Remove runtimeModule compiler option
1d969c8 
Now that the compiler always injects `react-compiler-runtime`, this
option is unnecessary.

ghstack-source-id: 6ad6822
ghstack-comment-id: 2397700297
Pull Request resolved: #31145
@poteto poteto force-pushed the gh/poteto/30/head branch from 0d8cf4b to c2c5431 Compare October 7, 2024 21:51
Base automatically changed from gh/poteto/30/head to main October 7, 2024 21:59
@poteto
Update
b42310e 
[ghstack-poisoned]
poteto added a commit that referenced this pull request Oct 7, 2024
@poteto
[rcr] Remove runtimeModule compiler option
35ebb7f 
Now that the compiler always injects `react-compiler-runtime`, this
option is unnecessary.

ghstack-source-id: 6ad6822
ghstack-comment-id: 2397700297
Pull Request resolved: #31145
@poteto poteto merged commit 23cd3ac into main Oct 7, 2024
19 checks passed
@poteto poteto deleted the gh/poteto/31/head branch October 7, 2024 22:07
This was referenced Oct 8, 2024
Closed
Closed
@poteto poteto mentioned this pull request Oct 10, 2024
Merged
9 tasks
This was referenced Oct 10, 2024
Closed
Closed
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@poteto @facebook-github-bot