Skip to content

[lint] Add no-optional-chaining #31003

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 19, 2024
Merged

[lint] Add no-optional-chaining #31003

merged 2 commits into from
Sep 19, 2024

Conversation

rickhanlonii
Copy link
Member

Overview

Adds a lint rule to prevent optional chaining to catch issues like #30982 until we support optional chaining without a bundle impact.

@vercel Vercel
Copy link

vercel bot commented Sep 19, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-compiler-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 19, 2024 5:22pm

@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Sep 19, 2024
@react-sizebot
Copy link

react-sizebot commented Sep 19, 2024 •
edited
Loading

Comparing: e740d4b...768d581

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB +0.11% 1.82 kB 1.83 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 508.22 kB 508.22 kB = 90.95 kB 90.95 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB +0.11% 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 513.15 kB 513.15 kB = 91.67 kB 91.67 kB
facebook-www/ReactDOM-prod.classic.js = 602.57 kB 602.57 kB = 106.64 kB 106.64 kB
facebook-www/ReactDOM-prod.modern.js = 578.84 kB 578.84 kB = 102.76 kB 102.76 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
oss-experimental/react-debug-tools/cjs/react-debug-tools.development.js = 32.36 kB 32.07 kB = 5.80 kB 5.75 kB
oss-stable-rc/react-debug-tools/cjs/react-debug-tools.development.js = 32.37 kB 32.07 kB = 5.80 kB 5.75 kB
oss-stable-semver/react-debug-tools/cjs/react-debug-tools.development.js = 32.37 kB 32.07 kB = 5.80 kB 5.75 kB
oss-stable/react-debug-tools/cjs/react-debug-tools.development.js = 32.37 kB 32.07 kB = 5.80 kB 5.75 kB
oss-experimental/react-debug-tools/cjs/react-debug-tools.production.js = 28.89 kB 28.60 kB = 5.67 kB 5.62 kB
oss-stable-rc/react-debug-tools/cjs/react-debug-tools.production.js = 28.89 kB 28.60 kB = 5.67 kB 5.62 kB
oss-stable-semver/react-debug-tools/cjs/react-debug-tools.production.js = 28.89 kB 28.60 kB = 5.67 kB 5.62 kB
oss-stable/react-debug-tools/cjs/react-debug-tools.production.js = 28.89 kB 28.60 kB = 5.67 kB 5.62 kB

Generated by 🚫 dangerJS against e6f19c0

@rickhanlonii rickhanlonii merged commit babde5d into facebook:main Sep 19, 2024
184 checks passed
This was referenced Sep 20, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kassens kassens kassens approved these changes

Assignees
No one assigned
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rickhanlonii @react-sizebot @kassens @facebook-github-bot