[compiler][hir] Correctly remove non-existent terminal preds when pruning labels #30076
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ning labels [ghstack-poisoned]
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This was referenced Jun 24, 2024
|
Comparing: 133ada7...01693b6 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: Expand to show
|
| @@ -67,4 +67,14 @@ export function pruneUnusedLabelsHIR(fn: HIRFunction): void { | |||
| fn.body.blocks.delete(fallthroughId); | |||
| rewrites.set(fallthroughId, labelId); | |||
| } | |||
|
|
|||
| for (const [_, block] of fn.body.blocks) { | |||
| for (const pred of [...block.preds]) { | |||
There was a problem hiding this comment.
Nit: let’s avoid the array copy here
josephsavona
approved these changes
Jun 25, 2024
…ds when pruning labels" Missed this initially in `pruneUnusedLabelsHIR`. It wasn't an active bug as `preds` wasn't referenced by later passes, until #30079 [ghstack-poisoned]
…ds when pruning labels" Missed this initially in `pruneUnusedLabelsHIR`. It wasn't an active bug as `preds` wasn't referenced by later passes, until #30079 [ghstack-poisoned]
This was referenced Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Missed this initially in
pruneUnusedLabelsHIR. It wasn't an active bug aspredswasn't referenced by later passes, until #30079