Skip to content

[compiler] Fork fixtures for enablePropagateDepsInHIR #30949

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 12, 2024
Merged

[compiler] Fork fixtures for enablePropagateDepsInHIR #30949

merged 2 commits into from
Sep 12, 2024

Conversation

mofeiZ
Copy link
Contributor

@mofeiZ mofeiZ commented Sep 11, 2024 •
edited
Loading

Stack from ghstack (oldest at bottom):

@mofeiZ
Update
af7261a 
[ghstack-poisoned]
@vercel Vercel
Copy link

vercel bot commented Sep 11, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-compiler-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 11, 2024 11:05pm

This was referenced Sep 11, 2024
Merged
Merged
@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Sep 11, 2024
@mofeiZ mofeiZ marked this pull request as ready for review September 11, 2024 22:58
@mofeiZ
Update
76d2565 
[ghstack-poisoned]
@mofeiZ mofeiZ merged commit 76d2565 into gh/mofeiZ/20/base Sep 12, 2024
19 checks passed
mofeiZ added a commit that referenced this pull request Sep 12, 2024
@mofeiZ
[compiler] Fork fixtures for enablePropagateDepsInHIR
5ac4034 
- flip `enablePropagateDepsInHIR` to off by default
- fork fixtures which produce compilation differences in #30894 to separate directory `propagate-scope-deps-hir-fork`, to be cleaned up when we remove this flag

ghstack-source-id: 7d5b8dc
Pull Request resolved: #30949
@mofeiZ mofeiZ deleted the gh/mofeiZ/20/head branch September 12, 2024 21:41
@vercel-release-bot vercel-release-bot mentioned this pull request Sep 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josephsavona josephsavona josephsavona approved these changes

Assignees
No one assigned
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mofeiZ @josephsavona @facebook-github-bot