Skip to content

[Flight] Preserve location of bound server actions #30778

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 22, 2024
Merged

[Flight] Preserve location of bound server actions #30778

merged 1 commit into from
Aug 22, 2024

Conversation

sebmarkbage
Copy link
Collaborator

Follow up to #30741.

We need to keep the location of the action when it's bound so we can still jump to it.

@sebmarkbage sebmarkbage requested review from gnoff and eps1lon August 21, 2024 18:32
@vercel Vercel
Copy link

vercel bot commented Aug 21, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-compiler-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 21, 2024 6:34pm

@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Aug 21, 2024
@react-sizebot
Copy link

Comparing: 1d98996...7144323

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB +0.05% 1.83 kB 1.83 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 500.37 kB 500.37 kB = 89.80 kB 89.80 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB +0.05% 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 507.50 kB 507.50 kB = 90.96 kB 90.96 kB
facebook-www/ReactDOM-prod.classic.js = 595.24 kB 595.24 kB = 105.55 kB 105.55 kB
facebook-www/ReactDOM-prod.modern.js = 571.54 kB 571.54 kB = 101.75 kB 101.75 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable-rc/react-server-dom-esm/cjs/react-server-dom-esm-server.node.development.js +0.27% 128.59 kB 128.93 kB +0.43% 23.87 kB 23.97 kB
oss-stable-semver/react-server-dom-esm/cjs/react-server-dom-esm-server.node.development.js +0.27% 128.59 kB 128.93 kB +0.43% 23.87 kB 23.97 kB
oss-stable/react-server-dom-esm/cjs/react-server-dom-esm-server.node.development.js +0.27% 128.59 kB 128.93 kB +0.43% 23.87 kB 23.97 kB
oss-stable-rc/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.browser.development.js +0.26% 132.32 kB 132.66 kB +0.44% 24.50 kB 24.61 kB
oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.browser.development.js +0.26% 132.32 kB 132.66 kB +0.44% 24.50 kB 24.61 kB
oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.browser.development.js +0.26% 132.32 kB 132.66 kB +0.44% 24.50 kB 24.61 kB
oss-stable-rc/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.edge.development.js +0.26% 133.69 kB 134.03 kB +0.42% 24.74 kB 24.84 kB
oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.edge.development.js +0.26% 133.69 kB 134.03 kB +0.42% 24.74 kB 24.84 kB
oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.edge.development.js +0.26% 133.69 kB 134.03 kB +0.42% 24.74 kB 24.84 kB
oss-stable-rc/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.development.js +0.25% 136.08 kB 136.42 kB +0.43% 25.13 kB 25.24 kB
oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.development.js +0.25% 136.08 kB 136.42 kB +0.43% 25.13 kB 25.24 kB
oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.development.js +0.25% 136.08 kB 136.42 kB +0.43% 25.13 kB 25.24 kB
oss-experimental/react-server-dom-esm/cjs/react-server-dom-esm-server.node.development.js +0.23% 148.13 kB 148.47 kB +0.37% 27.00 kB 27.10 kB
oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.browser.development.js +0.23% 151.02 kB 151.36 kB +0.38% 27.37 kB 27.48 kB
oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.edge.development.js +0.22% 154.03 kB 154.38 kB +0.38% 27.79 kB 27.90 kB
oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.development.js +0.22% 155.61 kB 155.95 kB +0.42% 28.27 kB 28.39 kB

Generated by 🚫 dangerJS against cd633db

@sebmarkbage sebmarkbage merged commit eb7570b into facebook:main Aug 22, 2024
184 checks passed
This was referenced Aug 27, 2024
Closed
Closed
Closed
Closed
Closed
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eps1lon eps1lon eps1lon approved these changes

@gnoff gnoff Awaiting requested review from gnoff

Assignees
No one assigned
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sebmarkbage @react-sizebot @eps1lon @facebook-github-bot