Skip to content

[Flight ESM] Wire up Source Maps in the flight-esm fixture #30758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 22, 2024
Merged

[Flight ESM] Wire up Source Maps in the flight-esm fixture #30758

merged 1 commit into from
Aug 22, 2024

Conversation

sebmarkbage
Copy link
Collaborator

Same as #29708 but for the flight-esm fixture.

@sebmarkbage sebmarkbage requested a review from gnoff August 20, 2024 20:09
@vercel Vercel
Copy link

vercel bot commented Aug 20, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-compiler-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 20, 2024 10:34pm

@sebmarkbage sebmarkbage requested a review from eps1lon August 20, 2024 20:09
@facebook-github-bot facebook-github-bot added the React Core Team Opened by a member of the React Core Team label Aug 20, 2024
@react-sizebot
Copy link

react-sizebot commented Aug 20, 2024 •
edited
Loading

Comparing: e831c23...88eb74f

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB +0.11% 1.82 kB 1.83 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 500.37 kB 500.37 kB = 89.80 kB 89.80 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB +0.05% 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 507.50 kB 507.50 kB = 90.96 kB 90.96 kB
facebook-www/ReactDOM-prod.classic.js = 595.24 kB 595.24 kB = 105.55 kB 105.55 kB
facebook-www/ReactDOM-prod.modern.js = 571.54 kB 571.54 kB = 101.75 kB 101.75 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against a8b901e

@sebmarkbage sebmarkbage mentioned this pull request Aug 20, 2024
Merged
@sebmarkbage sebmarkbage merged commit e483df4 into facebook:main Aug 22, 2024
185 checks passed
sebmarkbage added a commit that referenced this pull request Aug 22, 2024
@sebmarkbage
[Flight] Enable Server Action Source Maps in flight-esm Fixture (#30763)
97e2ce6 
Stacked on #30758 and #30755.

This is copy paste from #30755 into the ESM package. We use the
`webpack-sources` package for the source map utility but it's not
actually dependent on Webpack itself. Could probably inline it in the
build.
This was referenced Aug 27, 2024
Closed
Closed
Closed
Closed
Closed
Merged
Merged
@sebmarkbage sebmarkbage mentioned this pull request Dec 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eps1lon eps1lon eps1lon approved these changes

@gnoff gnoff Awaiting requested review from gnoff

Assignees
No one assigned
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sebmarkbage @react-sizebot @eps1lon @facebook-github-bot