Skip to content

[Flight] Revert Emit Infinite Promise as a Halted Row (#30746) #30748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 19, 2024
Merged

[Flight] Revert Emit Infinite Promise as a Halted Row (#30746) #30748

merged 1 commit into from
Aug 19, 2024

Conversation

sebmarkbage
Copy link
Collaborator

This reverts commit 52c9c43.

Just kidding. We realized we probably don't want to do the halted row thing after all.

@sebmarkbage sebmarkbage requested a review from gnoff August 19, 2024 20:31
@vercel Vercel
Copy link

vercel bot commented Aug 19, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-compiler-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 19, 2024 8:33pm

@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Aug 19, 2024
@sebmarkbage sebmarkbage merged commit 0fa9476 into facebook:main Aug 19, 2024
183 of 184 checks passed
@react-sizebot
Copy link

Comparing: 52c9c43...3f13315

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB = 1.83 kB 1.82 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 500.37 kB 500.37 kB = 89.80 kB 89.80 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB = 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 507.50 kB 507.50 kB = 90.96 kB 90.96 kB
facebook-www/ReactDOM-prod.classic.js = 595.24 kB 595.24 kB = 105.55 kB 105.55 kB
facebook-www/ReactDOM-prod.modern.js = 571.54 kB 571.54 kB = 101.75 kB 101.75 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
oss-experimental/react-server-dom-esm/esm/react-server-dom-esm-client.browser.production.js +0.21% 78.75 kB 78.92 kB +0.21% 16.68 kB 16.72 kB
oss-stable-rc/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.development.js = 135.50 kB 135.20 kB = 25.17 kB 25.12 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.development.js = 135.50 kB 135.20 kB = 25.17 kB 25.12 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.development.js = 135.50 kB 135.20 kB = 25.17 kB 25.12 kB
oss-stable-rc/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.development.js = 135.35 kB 135.05 kB = 25.11 kB 25.06 kB
oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.development.js = 135.35 kB 135.05 kB = 25.11 kB 25.06 kB
oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.development.js = 135.35 kB 135.05 kB = 25.11 kB 25.06 kB
oss-stable-rc/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.unbundled.development.js = 134.40 kB 134.10 kB = 24.89 kB 24.84 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.unbundled.development.js = 134.40 kB 134.10 kB = 24.89 kB 24.84 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.unbundled.development.js = 134.40 kB 134.10 kB = 24.89 kB 24.84 kB
oss-stable-rc/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.unbundled.development.js = 134.24 kB 133.94 kB = 24.83 kB 24.78 kB
oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.unbundled.development.js = 134.24 kB 133.94 kB = 24.83 kB 24.78 kB
oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.unbundled.development.js = 134.24 kB 133.94 kB = 24.83 kB 24.78 kB
oss-stable-rc/react-server-dom-esm/cjs/react-server-dom-esm-server.node.development.js = 127.87 kB 127.57 kB = 23.86 kB 23.81 kB
oss-stable-semver/react-server-dom-esm/cjs/react-server-dom-esm-server.node.development.js = 127.87 kB 127.57 kB = 23.86 kB 23.81 kB
oss-stable/react-server-dom-esm/cjs/react-server-dom-esm-server.node.development.js = 127.87 kB 127.57 kB = 23.86 kB 23.81 kB
oss-stable-rc/react-server-dom-webpack/cjs/react-server-dom-webpack-server.edge.development.js = 133.01 kB 132.68 kB = 24.78 kB 24.71 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-server.edge.development.js = 133.01 kB 132.68 kB = 24.78 kB 24.71 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-server.edge.development.js = 133.01 kB 132.68 kB = 24.78 kB 24.71 kB
oss-stable-rc/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.edge.development.js = 132.86 kB 132.53 kB = 24.71 kB 24.64 kB
oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.edge.development.js = 132.86 kB 132.53 kB = 24.71 kB 24.64 kB
oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.edge.development.js = 132.86 kB 132.53 kB = 24.71 kB 24.64 kB
oss-stable-rc/react-server-dom-webpack/cjs/react-server-dom-webpack-server.browser.development.js = 132.28 kB 131.94 kB = 24.68 kB 24.61 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-server.browser.development.js = 132.28 kB 131.94 kB = 24.68 kB 24.61 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-server.browser.development.js = 132.28 kB 131.94 kB = 24.68 kB 24.61 kB
oss-stable-rc/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.browser.development.js = 131.66 kB 131.32 kB = 24.49 kB 24.42 kB
oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.browser.development.js = 131.66 kB 131.32 kB = 24.49 kB 24.42 kB
oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.browser.development.js = 131.66 kB 131.32 kB = 24.49 kB 24.42 kB
oss-stable-rc/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.production.js = 57.02 kB 56.85 kB = 11.59 kB 11.56 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.production.js = 57.02 kB 56.85 kB = 11.59 kB 11.56 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.production.js = 57.02 kB 56.85 kB = 11.59 kB 11.56 kB
oss-stable-rc/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.unbundled.production.js = 56.33 kB 56.17 kB = 11.42 kB 11.39 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.unbundled.production.js = 56.33 kB 56.17 kB = 11.42 kB 11.39 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.unbundled.production.js = 56.33 kB 56.17 kB = 11.42 kB 11.39 kB
oss-stable-rc/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.development.js = 91.47 kB 91.19 kB = 17.28 kB 17.24 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.development.js = 91.47 kB 91.19 kB = 17.28 kB 17.24 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.development.js = 91.47 kB 91.19 kB = 17.28 kB 17.24 kB
oss-stable-rc/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.unbundled.development.js = 90.67 kB 90.39 kB = 17.10 kB 17.07 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.unbundled.development.js = 90.67 kB 90.39 kB = 17.10 kB 17.07 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.unbundled.development.js = 90.67 kB 90.39 kB = 17.10 kB 17.07 kB
oss-stable-rc/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.edge.development.js = 89.00 kB 88.72 kB = 17.04 kB 17.01 kB
oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.edge.development.js = 89.00 kB 88.72 kB = 17.04 kB 17.01 kB
oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.edge.development.js = 89.00 kB 88.72 kB = 17.04 kB 17.01 kB
oss-stable-rc/react-server-dom-webpack/cjs/react-server-dom-webpack-client.edge.development.js = 88.99 kB 88.70 kB = 17.05 kB 17.03 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-client.edge.development.js = 88.99 kB 88.70 kB = 17.05 kB 17.03 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-client.edge.development.js = 88.99 kB 88.70 kB = 17.05 kB 17.03 kB
oss-stable-rc/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.edge.production.js = 54.60 kB 54.42 kB = 11.29 kB 11.26 kB
oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.edge.production.js = 54.60 kB 54.42 kB = 11.29 kB 11.26 kB
oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.edge.production.js = 54.60 kB 54.42 kB = 11.29 kB 11.26 kB
oss-stable-rc/react-server-dom-webpack/cjs/react-server-dom-webpack-client.edge.production.js = 54.59 kB 54.41 kB = 11.30 kB 11.27 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-client.edge.production.js = 54.59 kB 54.41 kB = 11.30 kB 11.27 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-client.edge.production.js = 54.59 kB 54.41 kB = 11.30 kB 11.27 kB
oss-stable-rc/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.node.development.js = 87.62 kB 87.33 kB = 16.77 kB 16.74 kB
oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.node.development.js = 87.62 kB 87.33 kB = 16.77 kB 16.74 kB
oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.node.development.js = 87.62 kB 87.33 kB = 16.77 kB 16.74 kB
oss-stable-rc/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.node.production.js = 53.44 kB 53.27 kB = 11.07 kB 11.04 kB
oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.node.production.js = 53.44 kB 53.27 kB = 11.07 kB 11.04 kB
oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.node.production.js = 53.44 kB 53.27 kB = 11.07 kB 11.04 kB
oss-stable-rc/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.node.unbundled.development.js = 86.81 kB 86.52 kB = 16.61 kB 16.58 kB
oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.node.unbundled.development.js = 86.81 kB 86.52 kB = 16.61 kB 16.58 kB
oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.node.unbundled.development.js = 86.81 kB 86.52 kB = 16.61 kB 16.58 kB
oss-stable-rc/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.node.unbundled.production.js = 52.75 kB 52.57 kB = 10.92 kB 10.89 kB
oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.node.unbundled.production.js = 52.75 kB 52.57 kB = 10.92 kB 10.89 kB
oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.node.unbundled.production.js = 52.75 kB 52.57 kB = 10.92 kB 10.89 kB
oss-stable-rc/react-server-dom-esm/cjs/react-server-dom-esm-client.node.development.js = 85.40 kB 85.11 kB = 16.29 kB 16.27 kB
oss-stable-semver/react-server-dom-esm/cjs/react-server-dom-esm-client.node.development.js = 85.40 kB 85.11 kB = 16.29 kB 16.27 kB
oss-stable/react-server-dom-esm/cjs/react-server-dom-esm-client.node.development.js = 85.40 kB 85.11 kB = 16.29 kB 16.27 kB
oss-stable-rc/react-client/cjs/react-client-flight.production.js = 53.22 kB 53.04 kB = 9.82 kB 9.79 kB
oss-stable-semver/react-client/cjs/react-client-flight.production.js = 53.22 kB 53.04 kB = 9.82 kB 9.79 kB
oss-stable/react-client/cjs/react-client-flight.production.js = 53.22 kB 53.04 kB = 9.82 kB 9.79 kB
oss-stable-rc/react-server-dom-esm/cjs/react-server-dom-esm-client.node.production.js = 51.49 kB 51.31 kB = 10.63 kB 10.61 kB
oss-stable-semver/react-server-dom-esm/cjs/react-server-dom-esm-client.node.production.js = 51.49 kB 51.31 kB = 10.63 kB 10.61 kB
oss-stable/react-server-dom-esm/cjs/react-server-dom-esm-client.node.production.js = 51.49 kB 51.31 kB = 10.63 kB 10.61 kB
oss-stable-rc/react-server-dom-webpack/cjs/react-server-dom-webpack-client.browser.development.js = 82.76 kB 82.47 kB = 15.55 kB 15.53 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-client.browser.development.js = 82.76 kB 82.47 kB = 15.55 kB 15.53 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-client.browser.development.js = 82.76 kB 82.47 kB = 15.55 kB 15.53 kB
oss-stable-rc/react-client/cjs/react-client-flight.development.js = 82.02 kB 81.73 kB = 14.88 kB 14.83 kB
oss-stable-semver/react-client/cjs/react-client-flight.development.js = 82.02 kB 81.73 kB = 14.88 kB 14.83 kB
oss-stable/react-client/cjs/react-client-flight.development.js = 82.02 kB 81.73 kB = 14.88 kB 14.83 kB
oss-stable-rc/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.browser.development.js = 82.31 kB 82.02 kB = 15.44 kB 15.41 kB
oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.browser.development.js = 82.31 kB 82.02 kB = 15.44 kB 15.41 kB
oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.browser.development.js = 82.31 kB 82.02 kB = 15.44 kB 15.41 kB
oss-stable-rc/react-server-dom-esm/esm/react-server-dom-esm-client.browser.development.js = 114.96 kB 114.55 kB = 26.81 kB 26.72 kB
oss-stable-semver/react-server-dom-esm/esm/react-server-dom-esm-client.browser.development.js = 114.96 kB 114.55 kB = 26.81 kB 26.72 kB
oss-stable/react-server-dom-esm/esm/react-server-dom-esm-client.browser.development.js = 114.96 kB 114.55 kB = 26.81 kB 26.72 kB
oss-stable-rc/react-server-dom-webpack/cjs/react-server-dom-webpack-client.browser.production.js = 49.18 kB 49.00 kB = 10.09 kB 10.06 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-client.browser.production.js = 49.18 kB 49.00 kB = 10.09 kB 10.06 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-client.browser.production.js = 49.18 kB 49.00 kB = 10.09 kB 10.06 kB
oss-stable-rc/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.browser.production.js = 48.84 kB 48.67 kB = 10.00 kB 9.97 kB
oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.browser.production.js = 48.84 kB 48.67 kB = 10.00 kB 9.97 kB
oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.browser.production.js = 48.84 kB 48.67 kB = 10.00 kB 9.97 kB
oss-stable-rc/react-server-dom-esm/cjs/react-server-dom-esm-client.browser.production.js = 47.23 kB 47.06 kB = 9.63 kB 9.60 kB
oss-stable-semver/react-server-dom-esm/cjs/react-server-dom-esm-client.browser.production.js = 47.23 kB 47.06 kB = 9.63 kB 9.60 kB
oss-stable/react-server-dom-esm/cjs/react-server-dom-esm-client.browser.production.js = 47.23 kB 47.06 kB = 9.63 kB 9.60 kB
oss-stable-rc/react-server-dom-esm/esm/react-server-dom-esm-client.browser.production.js = 78.02 kB 77.59 kB = 16.58 kB 16.51 kB
oss-stable-semver/react-server-dom-esm/esm/react-server-dom-esm-client.browser.production.js = 78.02 kB 77.59 kB = 16.58 kB 16.51 kB
oss-stable/react-server-dom-esm/esm/react-server-dom-esm-client.browser.production.js = 78.02 kB 77.59 kB = 16.58 kB 16.51 kB
oss-stable-rc/react-server-dom-esm/cjs/react-server-dom-esm-client.browser.development.js = 80.45 kB 80.01 kB = 15.05 kB 15.02 kB
oss-stable-semver/react-server-dom-esm/cjs/react-server-dom-esm-client.browser.development.js = 80.45 kB 80.01 kB = 15.05 kB 15.02 kB
oss-stable/react-server-dom-esm/cjs/react-server-dom-esm-client.browser.development.js = 80.45 kB 80.01 kB = 15.05 kB 15.02 kB

Generated by 🚫 dangerJS against 8e1b6eb

@eps1lon eps1lon mentioned this pull request Aug 22, 2024
Merged
eps1lon added a commit to vercel/next.js that referenced this pull request Aug 23, 2024
@eps1lon
Update React from 1eaccd82-20240816 to eb3ad065-20240822 (#69196)
6c09bd9 
**breaking change for canary users: Bumps peer dependency of React from
`19.0.0-rc-1eaccd82-20240816` to `19.0.0-rc-eb3ad065-20240822`**

No changes required in Next.js it seems.

[diff
facebook/react@1eaccd82...eb3ad065](facebook/react@1eaccd8...eb3ad06)
<details>
<summary>React upstream changes</summary>

- facebook/react#30761
- facebook/react#30779
- facebook/react#30775
- facebook/react#30770
- facebook/react#30756
- facebook/react#30755
- facebook/react#30768
- facebook/react#30760
- facebook/react#30732
- facebook/react#30757
- facebook/react#30750
- facebook/react#30751
- facebook/react#30753
- facebook/react#30740
- facebook/react#30748
- facebook/react#30746
- facebook/react#30747
- facebook/react#30731
- facebook/react#30725
- facebook/react#30741
- facebook/react#30730
- facebook/react#30726
- facebook/react#30717
- facebook/react#30729
- facebook/react#30721
- facebook/react#30720
- facebook/react#30705

</details>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gnoff gnoff Awaiting requested review from gnoff

Assignees
No one assigned
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sebmarkbage @react-sizebot @facebook-github-bot