Skip to content

[compiler] Fix merging of queues states in InferReferenceEffects #29879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 12, 2024
Merged

[compiler] Fix merging of queues states in InferReferenceEffects #29879

merged 3 commits into from
Jun 12, 2024

Conversation

josephsavona
Copy link
Member

@josephsavona josephsavona commented Jun 12, 2024 •
edited
Loading

Stack from ghstack (oldest at bottom):

Fixes a bug found by @mofeiZ in #29878. When we merge queued states, if the new state does not introduce changes relative to the queued state we should use the queued state, not the new state.

@josephsavona
[compiler] Fix merging of queues states in InferReferenceEffects
0da1f32 
Fixes a bug found by @mofeiZ in #29878. When we merge queues states, if the new state does not introduce changes relative to the queued state we should use the queued state, not the new state.

[ghstack-poisoned]
@vercel Vercel
Copy link

vercel bot commented Jun 12, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-compiler-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 12, 2024 9:51pm

josephsavona added a commit that referenced this pull request Jun 12, 2024
@josephsavona
[compiler] Fix merging of queues states in InferReferenceEffects
af17497 
Fixes a bug found by mofeiZ in #29878. When we merge queues states, if the new state does not introduce changes relative to the queued state we should use the queued state, not the new state.

ghstack-source-id: cb931b7
Pull Request resolved: #29879
@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Jun 12, 2024
@react-sizebot
Copy link

react-sizebot commented Jun 12, 2024 •
edited
Loading

Comparing: 195d5bb...ac6ed0f

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.66 kB 6.66 kB = 1.82 kB 1.82 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 497.80 kB 497.80 kB = 89.24 kB 89.24 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.67 kB 6.67 kB = 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 502.62 kB 502.62 kB = 89.94 kB 89.94 kB
facebook-www/ReactDOM-prod.classic.js = 597.04 kB 597.04 kB = 105.31 kB 105.31 kB
facebook-www/ReactDOM-prod.modern.js = 571.38 kB 571.38 kB = 101.25 kB 101.25 kB
test_utils/ReactAllWarnings.js Deleted 62.88 kB 0.00 kB Deleted 15.69 kB 0.00 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
test_utils/ReactAllWarnings.js Deleted 62.88 kB 0.00 kB Deleted 15.69 kB 0.00 kB

Generated by 🚫 dangerJS against ac6ed0f

@josephsavona
Update on "[compiler] Fix merging of queues states in InferReferenceE…
ac6ed0f 
…ffects"

Fixes a bug found by mofeiZ in #29878. When we merge queues states, if the new state does not introduce changes relative to the queued state we should use the queued state, not the new state.

[ghstack-poisoned]
josephsavona added a commit that referenced this pull request Jun 12, 2024
@josephsavona
[compiler] Fix merging of queues states in InferReferenceEffects
5b54f5c 
Fixes a bug found by mofeiZ in #29878. When we merge queues states, if the new state does not introduce changes relative to the queued state we should use the queued state, not the new state.

ghstack-source-id: db0f5ab
Pull Request resolved: #29879
@josephsavona
Update on "[compiler] Fix merging of queues states in InferReferenceE…
c15c155 
…ffects"


Fixes a bug found by mofeiZ in #29878. When we merge queued states, if the new state does not introduce changes relative to the queued state we should use the queued state, not the new state.

[ghstack-poisoned]
josephsavona added a commit that referenced this pull request Jun 12, 2024
@josephsavona
[compiler] Fix merging of queued states in InferReferenceEffects
9d70a33 
Fixes a bug found by mofeiZ in #29878. When we merge queued states, if the new state does not introduce changes relative to the queued state we should use the queued state, not the new state.

ghstack-source-id: c59f69d
Pull Request resolved: #29879
@josephsavona josephsavona merged commit c15c155 into gh/josephsavona/29/base Jun 12, 2024
josephsavona added a commit that referenced this pull request Jun 12, 2024
@josephsavona
[compiler] Fix merging of queued states in InferReferenceEffects
55fdcf8 
Fixes a bug found by mofeiZ in #29878. When we merge queued states, if the new state does not introduce changes relative to the queued state we should use the queued state, not the new state.

ghstack-source-id: c59f69d
Pull Request resolved: #29879
@josephsavona josephsavona deleted the gh/josephsavona/29/head branch June 12, 2024 21:49
@josephsavona josephsavona mentioned this pull request Jun 12, 2024
Merged
@eps1lon eps1lon mentioned this pull request Jun 13, 2024
Merged
@eps1lon eps1lon mentioned this pull request Jul 10, 2024
Closed
This was referenced Jul 25, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@josephsavona @react-sizebot @facebook-github-bot