Remove ReactTestUtils from refs-destruction-test #28532

eps1lon · 2024-03-09T11:07:57Z

-expect(ReactTestUtils.isDOMComponent(maybeElement)).toBe(true);
+expect(maybeElement).toBeInstanceOf(Element);

It's not equivalent since isDOMComponent checks maybeElement.nodeType === Element.ELEMENT_NODE && !!maybeElement.tagName but instanceof check seems sufficient here. Checking nodeType is mostly for cross-realm checks and checking falsy tagName seems like a check specifically for incomplete DOM implementations because tagName can't be empty by spec I believe.

react-sizebot · 2024-03-09T11:11:19Z

Comparing: 850fac4...b851dbf

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name	+/-	Base	Current	+/- gzip	Base gzip	Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js	=	177.10 kB	177.10 kB	=	55.20 kB	55.20 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js	=	177.64 kB	177.64 kB	=	55.53 kB	55.53 kB
facebook-www/ReactDOM-prod.classic.js	=	594.34 kB	594.34 kB	=	104.96 kB	104.96 kB
facebook-www/ReactDOM-prod.modern.js	=	577.60 kB	577.60 kB	=	102.02 kB	102.02 kB
test_utils/ReactAllWarnings.js	Deleted	66.60 kB	0.00 kB	Deleted	16.28 kB	0.00 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show

Name	+/-	Base	Current	+/- gzip	Base gzip	Current gzip
test_utils/ReactAllWarnings.js	Deleted	66.60 kB	0.00 kB	Deleted	16.28 kB	0.00 kB

Generated by 🚫 dangerJS against b851dbf

…t-dom/test-util` (#28534) Batched the remaining usages since these were straight forward. Completes removal of `ReactTestUtils` from tests unrelated to `react-dom/test-util` together with: - #28531 - #28532 - #28533

…t-dom/test-util` (facebook#28534) Batched the remaining usages since these were straight forward. Completes removal of `ReactTestUtils` from tests unrelated to `react-dom/test-util` together with: - facebook#28531 - facebook#28532 - facebook#28533

```diff -expect(ReactTestUtils.isDOMComponent(maybeElement)).toBe(true); +expect(maybeElement).toBeInstanceOf(Element); ``` It's not equivalent since `isDOMComponent` checks `maybeElement.nodeType === Element.ELEMENT_NODE && !!maybeElement.tagName` but `instanceof` check seems sufficient here. Checking `nodeType` is mostly for cross-realm checks and checking falsy `tagName` seems like a check specifically for incomplete DOM implementations because tagName can't be empty by spec I believe.

```diff -expect(ReactTestUtils.isDOMComponent(maybeElement)).toBe(true); +expect(maybeElement).toBeInstanceOf(Element); ``` It's not equivalent since `isDOMComponent` checks `maybeElement.nodeType === Element.ELEMENT_NODE && !!maybeElement.tagName` but `instanceof` check seems sufficient here. Checking `nodeType` is mostly for cross-realm checks and checking falsy `tagName` seems like a check specifically for incomplete DOM implementations because tagName can't be empty by spec I believe. DiffTrain build for commit 9c48fb2.

…t-dom/test-util` (#28534) Batched the remaining usages since these were straight forward. Completes removal of `ReactTestUtils` from tests unrelated to `react-dom/test-util` together with: - facebook/react#28531 - facebook/react#28532 - facebook/react#28533 DiffTrain build for commit facebook/react@dfaed55.

Remove ReactTestUtils from refs-destruction-test

b851dbf

facebook-github-bot added the CLA Signed label Mar 9, 2024

eps1lon marked this pull request as ready for review March 9, 2024 11:08

facebook-github-bot added the React Core Team Opened by a member of the React Core Team label Mar 9, 2024

eps1lon mentioned this pull request Mar 9, 2024

Remove remaining usages of ReactTestUtils in tests unrelated to react-dom/test-util #28534

Merged

eps1lon mentioned this pull request Mar 11, 2024

ReactDOM: Remove every test-util except act() #28541

Merged

jackpope approved these changes Mar 11, 2024

View reviewed changes

eps1lon merged commit 9c48fb2 into facebook:main Mar 11, 2024

eps1lon deleted the test/test-util/refs-destruction branch March 11, 2024 21:11

ztanner mentioned this pull request Mar 18, 2024

Update React from 6c3b8dbfe to a4939017f vercel/next.js#63413

Closed

gnoff mentioned this pull request Mar 25, 2024

Update React from 14898b6a9 to e373190fa vercel/next.js#63685

Closed

ztanner mentioned this pull request Apr 2, 2024

Update React from 14898b6a9 to a870b2d54 vercel/next.js#63976

Closed

eps1lon mentioned this pull request Apr 19, 2024

Update React from 14898b6a9 to c3048aab4 vercel/next.js#64798

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Remove ReactTestUtils from refs-destruction-test #28532

Remove ReactTestUtils from refs-destruction-test #28532

Uh oh!

eps1lon commented Mar 9, 2024

Uh oh!

react-sizebot commented Mar 9, 2024

Uh oh!

Uh oh!

Remove ReactTestUtils from refs-destruction-test #28532

Remove ReactTestUtils from refs-destruction-test #28532

Uh oh!

Conversation

eps1lon commented Mar 9, 2024

Uh oh!

react-sizebot commented Mar 9, 2024

Critical size changes

Significant size changes

Uh oh!

Uh oh!