Skip to content

Move enableRenderableContext back to dynamic #28466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 27, 2024
Merged

Move enableRenderableContext back to dynamic #28466

merged 1 commit into from
Feb 27, 2024

Conversation

rickhanlonii
Copy link
Member

No description provided.

@rickhanlonii rickhanlonii changed the title Move enableRenderableContext back to experimental Move enableRenderableContext back to dynamic Feb 27, 2024
@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Feb 27, 2024
@react-sizebot
Copy link

Comparing: dee1aac...736ba06

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 176.89 kB 176.89 kB = 55.14 kB 55.14 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 179.00 kB 179.00 kB = 55.80 kB 55.81 kB
facebook-www/ReactDOM-prod.classic.js +0.25% 592.56 kB 594.04 kB +0.20% 104.73 kB 104.94 kB
facebook-www/ReactDOM-prod.modern.js +0.17% 576.34 kB 577.33 kB +0.14% 101.81 kB 101.96 kB
facebook-www/ReactIs-prod.classic.js +11.99% 5.21 kB 5.83 kB +6.66% 1.28 kB 1.36 kB
facebook-www/ReactIs-prod.modern.js +11.99% 5.21 kB 5.83 kB +6.66% 1.28 kB 1.36 kB
facebook-www/ReactIs-dev.modern.js +7.73% 7.70 kB 8.29 kB +3.20% 1.91 kB 1.97 kB
facebook-www/ReactIs-dev.classic.js +7.73% 7.70 kB 8.30 kB +3.35% 1.91 kB 1.97 kB
test_utils/ReactAllWarnings.js Deleted 66.40 kB 0.00 kB Deleted 16.26 kB 0.00 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
facebook-www/ReactIs-prod.classic.js +11.99% 5.21 kB 5.83 kB +6.66% 1.28 kB 1.36 kB
facebook-www/ReactIs-prod.modern.js +11.99% 5.21 kB 5.83 kB +6.66% 1.28 kB 1.36 kB
facebook-www/ReactIs-dev.modern.js +7.73% 7.70 kB 8.29 kB +3.20% 1.91 kB 1.97 kB
facebook-www/ReactIs-dev.classic.js +7.73% 7.70 kB 8.30 kB +3.35% 1.91 kB 1.97 kB
facebook-www/React-dev.modern.js +1.79% 121.99 kB 124.17 kB +0.97% 29.27 kB 29.55 kB
facebook-www/React-dev.classic.js +1.77% 123.57 kB 125.76 kB +0.94% 29.66 kB 29.94 kB
facebook-www/React-prod.modern.js +1.70% 19.95 kB 20.29 kB +0.91% 5.04 kB 5.09 kB
facebook-www/React-prod.classic.js +1.67% 20.24 kB 20.58 kB +0.94% 5.11 kB 5.15 kB
facebook-www/React-profiling.modern.js +1.66% 20.39 kB 20.73 kB +0.94% 5.12 kB 5.17 kB
facebook-www/React-profiling.classic.js +1.64% 20.67 kB 21.01 kB +0.91% 5.19 kB 5.23 kB
facebook-www/JSXDEVRuntime-dev.modern.js +0.97% 50.22 kB 50.71 kB +0.33% 13.22 kB 13.26 kB
facebook-www/JSXDEVRuntime-dev.classic.js +0.97% 50.23 kB 50.71 kB +0.32% 13.22 kB 13.26 kB
facebook-www/ReactServer-dev.modern.js +0.52% 93.41 kB 93.90 kB +0.22% 22.22 kB 22.27 kB
facebook-www/ReactART-prod.classic.js +0.41% 362.35 kB 363.83 kB +0.34% 61.71 kB 61.92 kB
facebook-www/ReactDOMServer-prod.modern.js +0.37% 203.61 kB 204.36 kB +0.43% 36.90 kB 37.06 kB
facebook-www/ReactDOMServer-prod.classic.js +0.37% 205.17 kB 205.92 kB +0.36% 37.22 kB 37.35 kB
facebook-www/ReactDOMServerStreaming-prod.modern.js +0.35% 207.50 kB 208.22 kB +0.35% 38.30 kB 38.43 kB
facebook-www/ReactART-prod.modern.js +0.28% 351.39 kB 352.38 kB +0.26% 59.76 kB 59.92 kB
facebook-www/ReactDOM-prod.classic.js +0.25% 592.56 kB 594.04 kB +0.20% 104.73 kB 104.94 kB
facebook-www/ReactDOMTesting-prod.classic.js +0.24% 607.34 kB 608.82 kB +0.20% 108.40 kB 108.63 kB
facebook-www/ReactDOM-profiling.classic.js +0.24% 623.00 kB 624.48 kB +0.20% 109.28 kB 109.50 kB
facebook-www/ReactDOMServerStreaming-dev.modern.js +0.22% 484.68 kB 485.74 kB +0.12% 98.55 kB 98.67 kB
facebook-www/ReactDOMTesting-prod.modern.js +0.22% 592.72 kB 594.01 kB +0.18% 105.90 kB 106.09 kB
facebook-www/ReactDOMServer-dev.modern.js +0.21% 491.91 kB 492.96 kB +0.12% 100.17 kB 100.30 kB
facebook-www/ReactDOMServer-dev.classic.js +0.21% 494.49 kB 495.54 kB +0.13% 100.65 kB 100.78 kB
test_utils/ReactAllWarnings.js Deleted 66.40 kB 0.00 kB Deleted 16.26 kB 0.00 kB

Generated by 🚫 dangerJS against 736ba06

@rickhanlonii rickhanlonii merged commit d88fb32 into main Feb 27, 2024
@rickhanlonii rickhanlonii deleted the rh/turn-off-render-context branch February 27, 2024 23:11
@ztanner ztanner mentioned this pull request Mar 18, 2024
Closed
gnoff added a commit to gnoff/next.js that referenced this pull request Mar 25, 2024
@gnoff
Update React from 14898b6a9 to e373190fa
d674a96 
- facebook/react#28596
- facebook/react#28625
- facebook/react#28616
- facebook/react#28491
- facebook/react#28583
- facebook/react#28427
- facebook/react#28613
- facebook/react#28599
- facebook/react#28611
- facebook/react#28610
- facebook/react#28606
- facebook/react#28598
- facebook/react#28549
- facebook/react#28557
- facebook/react#28467
- facebook/react#28591
- facebook/react#28459
- facebook/react#28590
- facebook/react#28564
- facebook/react#28582
- facebook/react#28579
- facebook/react#28578
- facebook/react#28521
- facebook/react#28550
- facebook/react#28576
- facebook/react#28577
- facebook/react#28571
- facebook/react#28572
- facebook/react#28560
- facebook/react#28569
- facebook/react#28573
- facebook/react#28546
- facebook/react#28568
- facebook/react#28562
- facebook/react#28566
- facebook/react#28565
- facebook/react#28559
- facebook/react#28508
- facebook/react#20432
- facebook/react#28555
- facebook/react#24730
- facebook/react#28472
- facebook/react#27991
- facebook/react#28514
- facebook/react#28548
- facebook/react#28526
- facebook/react#28515
- facebook/react#28533
- facebook/react#28532
- facebook/react#28531
- facebook/react#28407
- facebook/react#28522
- facebook/react#28538
- facebook/react#28509
- facebook/react#28534
- facebook/react#28527
- facebook/react#28528
- facebook/react#28519
- facebook/react#28411
- facebook/react#28520
- facebook/react#28518
- facebook/react#28493
- facebook/react#28504
- facebook/react#28499
- facebook/react#28501
- facebook/react#28496
- facebook/react#28471
- facebook/react#28351
- facebook/react#28486
- facebook/react#28490
- facebook/react#28488
- facebook/react#28468
- facebook/react#28321
- facebook/react#28477
- facebook/react#28479
- facebook/react#28480
- facebook/react#28478
- facebook/react#28464
- facebook/react#28475
- facebook/react#28456
- facebook/react#28319
- facebook/react#28345
- facebook/react#28337
- facebook/react#28335
- facebook/react#28466
- facebook/react#28462
- facebook/react#28322
- facebook/react#28444
- facebook/react#28448
- facebook/react#28449
- facebook/react#28446
- facebook/react#28447
- facebook/react#24580
- facebook/react#28514
- facebook/react#28548
- facebook/react#28526
- facebook/react#28515
- facebook/react#28533
- facebook/react#28532
- facebook/react#28531
- facebook/react#28407
- facebook/react#28522
- facebook/react#28538
- facebook/react#28509
- facebook/react#28534
- facebook/react#28527
- facebook/react#28528
- facebook/react#28519
- facebook/react#28411
- facebook/react#28520
- facebook/react#28518
- facebook/react#28493
- facebook/react#28504
- facebook/react#28499
- facebook/react#28501
- facebook/react#28496
- facebook/react#28471
- facebook/react#28351
- facebook/react#28486
- facebook/react#28490
- facebook/react#28488
- facebook/react#28468
- facebook/react#28321
- facebook/react#28477
- facebook/react#28479
- facebook/react#28480
- facebook/react#28478
- facebook/react#28464
- facebook/react#28475
- facebook/react#28456
- facebook/react#28319
- facebook/react#28345
- facebook/react#28337
- facebook/react#28335
- facebook/react#28466
- facebook/react#28462
- facebook/react#28322
- facebook/react#28444
- facebook/react#28448
- facebook/react#28449
- facebook/react#28446
- facebook/react#28447
- facebook/react#24580
@gnoff gnoff mentioned this pull request Mar 25, 2024
Closed
gnoff added a commit to gnoff/next.js that referenced this pull request Mar 25, 2024
@gnoff
Update React from 14898b6a9 to e373190fa
1a2ce1f 
- facebook/react#28596
- facebook/react#28625
- facebook/react#28616
- facebook/react#28491
- facebook/react#28583
- facebook/react#28427
- facebook/react#28613
- facebook/react#28599
- facebook/react#28611
- facebook/react#28610
- facebook/react#28606
- facebook/react#28598
- facebook/react#28549
- facebook/react#28557
- facebook/react#28467
- facebook/react#28591
- facebook/react#28459
- facebook/react#28590
- facebook/react#28564
- facebook/react#28582
- facebook/react#28579
- facebook/react#28578
- facebook/react#28521
- facebook/react#28550
- facebook/react#28576
- facebook/react#28577
- facebook/react#28571
- facebook/react#28572
- facebook/react#28560
- facebook/react#28569
- facebook/react#28573
- facebook/react#28546
- facebook/react#28568
- facebook/react#28562
- facebook/react#28566
- facebook/react#28565
- facebook/react#28559
- facebook/react#28508
- facebook/react#20432
- facebook/react#28555
- facebook/react#24730
- facebook/react#28472
- facebook/react#27991
- facebook/react#28514
- facebook/react#28548
- facebook/react#28526
- facebook/react#28515
- facebook/react#28533
- facebook/react#28532
- facebook/react#28531
- facebook/react#28407
- facebook/react#28522
- facebook/react#28538
- facebook/react#28509
- facebook/react#28534
- facebook/react#28527
- facebook/react#28528
- facebook/react#28519
- facebook/react#28411
- facebook/react#28520
- facebook/react#28518
- facebook/react#28493
- facebook/react#28504
- facebook/react#28499
- facebook/react#28501
- facebook/react#28496
- facebook/react#28471
- facebook/react#28351
- facebook/react#28486
- facebook/react#28490
- facebook/react#28488
- facebook/react#28468
- facebook/react#28321
- facebook/react#28477
- facebook/react#28479
- facebook/react#28480
- facebook/react#28478
- facebook/react#28464
- facebook/react#28475
- facebook/react#28456
- facebook/react#28319
- facebook/react#28345
- facebook/react#28337
- facebook/react#28335
- facebook/react#28466
- facebook/react#28462
- facebook/react#28322
- facebook/react#28444
- facebook/react#28448
- facebook/react#28449
- facebook/react#28446
- facebook/react#28447
- facebook/react#24580
@ztanner ztanner mentioned this pull request Apr 2, 2024
Closed
EdisonVan pushed a commit to EdisonVan/react that referenced this pull request Apr 15, 2024
@rickhanlonii @AndyPengc12
Move enableRenderableContext back to dynamic (facebook#28466)
dfd3070
bigfootjon pushed a commit that referenced this pull request Apr 18, 2024
@rickhanlonii
Move enableRenderableContext back to dynamic (#28466)
a969bc1 
DiffTrain build for commit d88fb32.
eps1lon added a commit to vercel/next.js that referenced this pull request Apr 19, 2024
@eps1lon
Update React from 14898b6a9 to c3048aab4.
fc58bbc 
### React upstream changes

- facebook/react#28643
- facebook/react#28628
- facebook/react#28361
- facebook/react#28513
- facebook/react#28299
- facebook/react#28617
- facebook/react#28618
- facebook/react#28621
- facebook/react#28614
- facebook/react#28596
- facebook/react#28625
- facebook/react#28616
- facebook/react#28491
- facebook/react#28583
- facebook/react#28427
- facebook/react#28613
- facebook/react#28599
- facebook/react#28611
- facebook/react#28610
- facebook/react#28606
- facebook/react#28598
- facebook/react#28549
- facebook/react#28557
- facebook/react#28467
- facebook/react#28591
- facebook/react#28459
- facebook/react#28590
- facebook/react#28564
- facebook/react#28582
- facebook/react#28579
- facebook/react#28578
- facebook/react#28521
- facebook/react#28550
- facebook/react#28576
- facebook/react#28577
- facebook/react#28571
- facebook/react#28572
- facebook/react#28560
- facebook/react#28569
- facebook/react#28573
- facebook/react#28546
- facebook/react#28568
- facebook/react#28562
- facebook/react#28566
- facebook/react#28565
- facebook/react#28559
- facebook/react#28508
- facebook/react#20432
- facebook/react#28555
- facebook/react#24730
- facebook/react#28472
- facebook/react#27991
- facebook/react#28514
- facebook/react#28548
- facebook/react#28526
- facebook/react#28515
- facebook/react#28533
- facebook/react#28532
- facebook/react#28531
- facebook/react#28407
- facebook/react#28522
- facebook/react#28538
- facebook/react#28509
- facebook/react#28534
- facebook/react#28527
- facebook/react#28528
- facebook/react#28519
- facebook/react#28411
- facebook/react#28520
- facebook/react#28518
- facebook/react#28493
- facebook/react#28504
- facebook/react#28499
- facebook/react#28501
- facebook/react#28496
- facebook/react#28471
- facebook/react#28351
- facebook/react#28486
- facebook/react#28490
- facebook/react#28488
- facebook/react#28468
- facebook/react#28321
- facebook/react#28477
- facebook/react#28479
- facebook/react#28480
- facebook/react#28478
- facebook/react#28464
- facebook/react#28475
- facebook/react#28456
- facebook/react#28319
- facebook/react#28345
- facebook/react#28337
- facebook/react#28335
- facebook/react#28466
- facebook/react#28462
- facebook/react#28322
- facebook/react#28444
- facebook/react#28448
- facebook/react#28449
- facebook/react#28446
- facebook/react#28447
- facebook/react#24580
- facebook/react#28514
- facebook/react#28548
- facebook/react#28526
- facebook/react#28515
- facebook/react#28533
- facebook/react#28532
- facebook/react#28531
- facebook/react#28407
- facebook/react#28522
- facebook/react#28538
- facebook/react#28509
- facebook/react#28534
- facebook/react#28527
- facebook/react#28528
- facebook/react#28519
- facebook/react#28411
- facebook/react#28520
- facebook/react#28518
- facebook/react#28493
- facebook/react#28504
- facebook/react#28499
- facebook/react#28501
- facebook/react#28496
- facebook/react#28471
- facebook/react#28351
- facebook/react#28486
- facebook/react#28490
- facebook/react#28488
- facebook/react#28468
- facebook/react#28321
- facebook/react#28477
- facebook/react#28479
- facebook/react#28480
- facebook/react#28478
- facebook/react#28464
- facebook/react#28475
- facebook/react#28456
- facebook/react#28319
- facebook/react#28345
- facebook/react#28337
- facebook/react#28335
- facebook/react#28466
- facebook/react#28462
- facebook/react#28322
- facebook/react#28444
- facebook/react#28448
- facebook/react#28449
- facebook/react#28446
- facebook/react#28447
- facebook/react#24580
@eps1lon eps1lon mentioned this pull request Apr 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kassens kassens kassens approved these changes

@mofeiZ mofeiZ mofeiZ approved these changes

Assignees
No one assigned
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rickhanlonii @react-sizebot @kassens @mofeiZ @facebook-github-bot