fix[devtools/extension]: handle tab navigation events before react is loaded #27316

hoxyq · 2023-08-30T18:19:57Z

This is mostly hotfix for #27215.

Contains 3 fixes:

Handle cases when react is not loaded yet and user performs in-tab navigation. Previously, because of the uncleared interval we would try to mount DevTools twice, resulting into multiple errors.
Handle case when extension port disconnected (probably by the browser or just due to its lifetime)
Removed duplicate render() call on line 327

… loaded

List of changes: * fix[devtools/extension]: handle tab navigation events before react is loaded ([hoxyq](https://github.com/hoxyq) in [#27316](#27316))

… loaded (facebook#27316) This is mostly hotfix for facebook#27215. Contains 3 fixes: - Handle cases when `react` is not loaded yet and user performs in-tab navigation. Previously, because of the uncleared interval we would try to mount DevTools twice, resulting into multiple errors. - Handle case when extension port disconnected (probably by the browser or just due to its lifetime) - Removed duplicate `render()` call on line 327

List of changes: * fix[devtools/extension]: handle tab navigation events before react is loaded ([hoxyq](https://github.com/hoxyq) in [facebook#27316](facebook#27316))

… loaded (#27316) This is mostly hotfix for #27215. Contains 3 fixes: - Handle cases when `react` is not loaded yet and user performs in-tab navigation. Previously, because of the uncleared interval we would try to mount DevTools twice, resulting into multiple errors. - Handle case when extension port disconnected (probably by the browser or just due to its lifetime) - Removed duplicate `render()` call on line 327 DiffTrain build for commit 29b405b.

List of changes: * fix[devtools/extension]: handle tab navigation events before react is loaded ([hoxyq](https://github.com/hoxyq) in [#27316](facebook/react#27316)) DiffTrain build for commit facebook/react@3808b01.

fix[devtools/extension]: handle tab navigation events before react is…

a6d73e8

… loaded

facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Aug 30, 2023

hoxyq merged commit 29b405b into facebook:main Aug 30, 2023

hoxyq deleted the devtools/handle-tab-navigation-before-react-is-loaded branch August 30, 2023 18:31

hoxyq mentioned this pull request Aug 30, 2023

React DevTools 4.28.1 -> 4.28.2 #27318

Merged

hoxyq added a commit that referenced this pull request Aug 30, 2023

React DevTools 4.28.1 -> 4.28.2 (#27318)

3808b01

List of changes: * fix[devtools/extension]: handle tab navigation events before react is loaded ([hoxyq](https://github.com/hoxyq) in [#27316](#27316))

acdlite mentioned this pull request Sep 14, 2023

Update React from dd480ef92 to d6dcad6a8. vercel/next.js#55399

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix[devtools/extension]: handle tab navigation events before react is loaded #27316

fix[devtools/extension]: handle tab navigation events before react is loaded #27316

Uh oh!

hoxyq commented Aug 30, 2023

Uh oh!

Uh oh!

fix[devtools/extension]: handle tab navigation events before react is loaded #27316

fix[devtools/extension]: handle tab navigation events before react is loaded #27316

Uh oh!

Conversation

hoxyq commented Aug 30, 2023

Uh oh!

Uh oh!