refactor[devtools/extension]: minify production builds to strip comments #27304

hoxyq · 2023-08-29T10:43:44Z

Currently, we are unable to publish a release to Firefox extensions store, due to parseHookNames chunk size, which is ~5mb.

We were not minifying production builds on purpose, to have more descriptive error messages. Now, Terser plugin will only:

remove comments
mangle, but keeping function names (for understandable bug reports)

List of changes: * refactor: refactored devtools browser extension scripts to improve port management and service worker lifetime ([hoxyq](https://github.com/hoxyq) in [#27215](#27215)) * refactor[devtools/extension]: minify production builds to strip comments ([hoxyq](https://github.com/hoxyq) in [#27304](#27304)) * fix[devtools]: allow element updates polling only if bridge is alive ([hoxyq](https://github.com/hoxyq) in [#27067](#27067)) * refactor: resolve browser via env variables based on build rather than user agent ([hoxyq](https://github.com/hoxyq) in [#27179](#27179)) * fix[devtools/updateFiberRecursively]: mount suspense fallback set in timed out case ([hoxyq](https://github.com/hoxyq) in [#27147](#27147)) * Feat:-Added open in editor to appear by default ([Biki-das](https://github.com/Biki-das) in [#26949](#26949)) * fix[devtools/inspect]: null check memoized props before trying to call hasOwnProperty ([hoxyq](https://github.com/hoxyq) in [#27057](#27057)) * rename SuspenseList export to unstable_SuspenseList ([noahlemen](https://github.com/noahlemen) in [#27061](#27061))

…nts (facebook#27304) Currently, we are unable to publish a release to Firefox extensions store, due to `parseHookNames` chunk size, which is ~5mb. We were not minifying production builds on purpose, to have more descriptive error messages. Now, Terser plugin will only: - remove comments - mangle, but keeping function names (for understandable bug reports)

List of changes: * refactor: refactored devtools browser extension scripts to improve port management and service worker lifetime ([hoxyq](https://github.com/hoxyq) in [facebook#27215](facebook#27215)) * refactor[devtools/extension]: minify production builds to strip comments ([hoxyq](https://github.com/hoxyq) in [facebook#27304](facebook#27304)) * fix[devtools]: allow element updates polling only if bridge is alive ([hoxyq](https://github.com/hoxyq) in [facebook#27067](facebook#27067)) * refactor: resolve browser via env variables based on build rather than user agent ([hoxyq](https://github.com/hoxyq) in [facebook#27179](facebook#27179)) * fix[devtools/updateFiberRecursively]: mount suspense fallback set in timed out case ([hoxyq](https://github.com/hoxyq) in [facebook#27147](facebook#27147)) * Feat:-Added open in editor to appear by default ([Biki-das](https://github.com/Biki-das) in [facebook#26949](facebook#26949)) * fix[devtools/inspect]: null check memoized props before trying to call hasOwnProperty ([hoxyq](https://github.com/hoxyq) in [facebook#27057](facebook#27057)) * rename SuspenseList export to unstable_SuspenseList ([noahlemen](https://github.com/noahlemen) in [facebook#27061](facebook#27061))

…nts (#27304) Currently, we are unable to publish a release to Firefox extensions store, due to `parseHookNames` chunk size, which is ~5mb. We were not minifying production builds on purpose, to have more descriptive error messages. Now, Terser plugin will only: - remove comments - mangle, but keeping function names (for understandable bug reports) DiffTrain build for commit f479562.

List of changes: * refactor: refactored devtools browser extension scripts to improve port management and service worker lifetime ([hoxyq](https://github.com/hoxyq) in [#27215](facebook/react#27215)) * refactor[devtools/extension]: minify production builds to strip comments ([hoxyq](https://github.com/hoxyq) in [#27304](facebook/react#27304)) * fix[devtools]: allow element updates polling only if bridge is alive ([hoxyq](https://github.com/hoxyq) in [#27067](facebook/react#27067)) * refactor: resolve browser via env variables based on build rather than user agent ([hoxyq](https://github.com/hoxyq) in [#27179](facebook/react#27179)) * fix[devtools/updateFiberRecursively]: mount suspense fallback set in timed out case ([hoxyq](https://github.com/hoxyq) in [#27147](facebook/react#27147)) * Feat:-Added open in editor to appear by default ([Biki-das](https://github.com/Biki-das) in [#26949](facebook/react#26949)) * fix[devtools/inspect]: null check memoized props before trying to call hasOwnProperty ([hoxyq](https://github.com/hoxyq) in [#27057](facebook/react#27057)) * rename SuspenseList export to unstable_SuspenseList ([noahlemen](https://github.com/noahlemen) in [#27061](facebook/react#27061)) DiffTrain build for commit facebook/react@2f36872.

refactor[devtools/extension]: minify production builds to strip comments

64a1795

facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Aug 29, 2023

hoxyq merged commit f479562 into facebook:main Aug 29, 2023

hoxyq deleted the devtools/minify-production-build branch August 29, 2023 11:09

hoxyq mentioned this pull request Aug 29, 2023

React DevTools 4.28.0 -> 4.28.1 #27305

Merged

acdlite mentioned this pull request Sep 14, 2023

Update React from dd480ef92 to d6dcad6a8. vercel/next.js#55399

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

refactor[devtools/extension]: minify production builds to strip comments #27304

refactor[devtools/extension]: minify production builds to strip comments #27304

Uh oh!

hoxyq commented Aug 29, 2023

Uh oh!

Uh oh!

refactor[devtools/extension]: minify production builds to strip comments #27304

refactor[devtools/extension]: minify production builds to strip comments #27304

Uh oh!

Conversation

hoxyq commented Aug 29, 2023

Uh oh!

Uh oh!