Skip to content

Flow upgrade to 0.145 #25409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 4, 2022
Merged

Flow upgrade to 0.145 #25409

merged 1 commit into from
Oct 4, 2022

Conversation

kassens
Copy link
Member

@kassens kassens commented Oct 4, 2022 •
edited
Loading

Stack from ghstack (oldest at bottom):

Fixed a RN library definition that defined CustomEvent as a reference to itself.

@kassens
Flow upgrade to 0.145
c3f2114 
Fixed a RN library definition that defined `CustomEvent` as a reference to itself.

[ghstack-poisoned]
This was referenced Oct 4, 2022
Merged
Merged
@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Oct 4, 2022
kassens added a commit to kassens/react that referenced this pull request Oct 4, 2022
@kassens
Flow upgrade to 0.145
92cf0e6 
Fixed a RN library definition that defined `CustomEvent` as a reference to itself.

ghstack-source-id: 90da2e3
Pull Request resolved: facebook#25409
@sizebot
Copy link

sizebot commented Oct 4, 2022

Comparing: 0a30722...c3f2114

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 135.46 kB 135.46 kB = 43.41 kB 43.41 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 147.72 kB 147.72 kB = 47.17 kB 47.17 kB
facebook-www/ReactDOM-prod.classic.js = 491.70 kB 491.70 kB = 87.49 kB 87.49 kB
facebook-www/ReactDOM-prod.modern.js = 477.00 kB 477.00 kB = 85.24 kB 85.24 kB
facebook-www/ReactDOMForked-prod.classic.js = 491.70 kB 491.70 kB = 87.49 kB 87.49 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against c3f2114

@kassens kassens merged commit c3f2114 into gh/kassens/2/base Oct 4, 2022
kassens added a commit that referenced this pull request Oct 4, 2022
@kassens
Flow upgrade to 0.145
d3c6c16 
Fixed a RN library definition that defined `CustomEvent` as a reference to itself.

ghstack-source-id: 90da2e3
Pull Request resolved: #25409
@kassens kassens deleted the gh/kassens/2/head branch October 4, 2022 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaearon gaearon gaearon approved these changes

Assignees
No one assigned
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kassens @sizebot @gaearon @facebook-github-bot