Test suite for hydration diff warnings #24229
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaearon
commented
Mar 31, 2022
gaearon
commented
Mar 31, 2022
| in Mismatch (at **)", | ||
| "Warning: An error occurred during hydration. The server HTML was replaced with client content in <div>.", | ||
| "Caught [Hydration failed because the initial UI does not match what was rendered on the server.]", | ||
| "Caught [Hydration failed because the initial UI does not match what was rendered on the server.]", |
There was a problem hiding this comment.
Curious that this error shows up twice.
|
Comparing: b76103d...d55ca42 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: (No significant changes) |
|
Hmm apparently snapshot tests don't work with our "expect to fail" thing... |
salazarm
approved these changes
Mar 31, 2022
rickhanlonii
pushed a commit
that referenced
this pull request
Apr 13, 2022
* Test suite for hydration diff warnings * Test both variants * Add more edge cases
rickhanlonii
pushed a commit
that referenced
this pull request
Apr 14, 2022
* Test suite for hydration diff warnings * Test both variants * Add more edge cases
rickhanlonii
pushed a commit
that referenced
this pull request
Apr 14, 2022
* Test suite for hydration diff warnings * Test both variants * Add more edge cases
zhengjitf
pushed a commit
to zhengjitf/react
that referenced
this pull request
Apr 15, 2022
* Test suite for hydration diff warnings * Test both variants * Add more edge cases
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation for #24167.
If we're doing something more ambitious like #24167 (comment) I want to have good coverage of different cases and make sure the right thing is being printed. There are existing tests in different places but I want to have an exhaustive suite dedicated just to this, and ideally it should be easy to iterate on. So I made these inline snapshots.
This just documents the current behavior. Follow-up will change the messages.