-
Notifications
You must be signed in to change notification settings - Fork 49.2k
[DevTools] Add options for disabling some features #22136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall. Added some small nits.
packages/react-devtools-shared/src/devtools/views/Components/InspectedElementPropsTree.js
Outdated
Show resolved
Hide resolved
packages/react-devtools-shared/src/devtools/views/Components/KeyValue.js
Outdated
Show resolved
Hide resolved
packages/react-devtools-shared/src/devtools/views/Components/InspectedElement.js
Outdated
Show resolved
Hide resolved
packages/react-devtools-shared/src/devtools/views/Components/InspectedElement.js
Outdated
Show resolved
Hide resolved
packages/react-devtools-shared/src/devtools/views/Components/InspectedElementSuspenseToggle.js
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. Added a few small nits. If you don't mind making them, awesome. If not, I can make them. No big deal either way.
packages/react-devtools-shared/src/devtools/views/Components/InspectedElementPropsTree.js
Outdated
Show resolved
Hide resolved
packages/react-devtools-shared/src/devtools/views/Components/KeyValue.js
Outdated
Show resolved
Hide resolved
packages/react-devtools-shared/src/devtools/views/Components/KeyValue.js
Outdated
Show resolved
Hide resolved
packages/react-devtools-shared/src/devtools/views/Components/KeyValue.js
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Thank you 🙇🏼
React DevTools 4.17 has been published with this feature. |
We have successfully integrated react-devtools-inline in the Replay frontend. Now we want to disable some features in the UI that either make no sense in our setting or haven't been implemented yet.
This PR adds some props for that to the DevTools component:
readOnly
will disable editing any values in the Component inspectorhideSettings
will hide the button for opening the settings panelhideToggleErrorAction
will hide the button for toggling a component's error statehideToggleSuspenseAction
will hide the button for toggling a component's suspense statehideLogAction
will hide the button to log a component's data to the consolehideViewSourceAction
will hide the button for viewing the component's sourceFurthermore, it adds the
supportsNativeInspection
option to thecreateStore()
function, passing it to theStore
constructor.The CLA has been signed for the RecordReplay organization.