[Native] Add FeatureFlag to dispatch events with instance currentTarget #17345
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebmarkbage
approved these changes
Nov 11, 2019
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit a6ad34c:
|
Details of bundled changes.Comparing: 2c6ea0b...a6ad34c react-native-renderer
Size changes (experimental) |
Details of bundled changes.Comparing: 2c6ea0b...a6ad34c react-native-renderer
Size changes (stable) |
bbc0990 to
a6ad34c
Compare
elicwhite
added a commit
to elicwhite/react
that referenced
this pull request
Dec 19, 2019
…et (facebook#17345) * [Native] Add FeatureFlag to dispatch events with instance targets * Prettier * [Native] Change currentTarget to be an instance behind a flag 2/2
elicwhite
added a commit
to elicwhite/react
that referenced
this pull request
Jan 8, 2020
…et (facebook#17345) * [Native] Add FeatureFlag to dispatch events with instance targets * Prettier * [Native] Change currentTarget to be an instance behind a flag 2/2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dependent on #17323 to make event.currentTarget an instance instead of a reactTag.
I tested this in RNTester in React Native ensuring that Touchable and Pressable correctly handle the updated currentTarget. I have found no other internal callsite referencing this value.