Change legacy-events plugin nativeEventTarget to allow null #17344
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 3daa736:
|
sebmarkbage
approved these changes
Nov 11, 2019
elicwhite
added a commit
to elicwhite/react
that referenced
this pull request
Dec 19, 2019
elicwhite
added a commit
to elicwhite/react
that referenced
this pull request
Jan 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
React Native is changing the event target to be a react element instance instead of a reactTag. We pull this element instance off of the fiber, which might be null, thus the target might now be null.
It looks like the only thing that uses the target is SyntheticEvent which just sets it on the event:
react/packages/legacy-events/SyntheticEvent.js
Lines 93 to 95 in 6cff70a